Commit Graph

871 Commits

Author SHA1 Message Date
Jim Meyering
cc6eed7042 in progress: avoid warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1943 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:13:47 +00:00
Jim Meyering
3baa7fa9ce avoid 7 warnings
(struct sync_callbacks), (struct corosync_service_engine) [name]:
Make member const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1939 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:13:02 +00:00
Jim Meyering
8bcbde3c08 totem*: add "const" to avoid 3 more warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1937 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:12:31 +00:00
Jim Meyering
3ec95b158b totem*: add "const" to avoid 1 more warning
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1936 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:12:19 +00:00
Jim Meyering
f7152d349a totem*: add "const" to avoid 1 more warning
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1935 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:12:11 +00:00
Jim Meyering
9613fe0944 totemconfig.c: avoid another warning
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1933 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:11:55 +00:00
Jim Meyering
88a407f40a * exec/totemconfig.c: eliminate 8 const-related warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1932 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:11:46 +00:00
Jim Meyering
87b6a141ff * exec/objdb.c (object_create): make "object_name" param const
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1930 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:11:25 +00:00
Jim Meyering
b107445d5a objdb.c, etc: add "const" to avoid warnings
* exec/objdb.c:
* include/corosync/engine/coroapi.h:
* include/corosync/engine/objdb.h:

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1928 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:11:09 +00:00
Jim Meyering
7c2ddcbe40 service.[ch]: remove 7 const-related warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1925 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:10:45 +00:00
Jim Meyering
f42de14a5a coroipcs.[ch]: remove 4 const-related warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1924 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:10:37 +00:00
Jim Meyering
921a5a8417 totempg.c: remove one const-related warning
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1923 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:10:30 +00:00
Jim Meyering
b94d4f6ae4 totempg.c: remove one const-related warning
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1921 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:10:13 +00:00
Jim Meyering
e487affc01 logsys_config_facility_set: make "name" parameter const
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1919 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:09:56 +00:00
Jim Meyering
2344e2f1b8 cfg.c: nearly warning-free
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1918 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:09:47 +00:00
Jim Meyering
1919ff31c7 cpg.c: resolve almost all warnings
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1917 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 21:09:38 +00:00
Jim Meyering
767e64ff4d timer.c: don't infloop upon poll failure (e.g., ENOMEM)
* exec/timer.c (prioritized_timer_thread): Remove unreached
call to pthread_exit after infloop.
Return NULL for any poll failure other than EINTR.
Use "continue" rather than an equivalent "goto".
Return NULL upon failed pthread_setschedparam.
This also avoids a warning.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1916 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 16:33:39 +00:00
Jim Meyering
217c5bed8d logsys: detect write failure and avoid a file descriptor leak
* exec/logsys.c (logsys_log_rec_store): Close output file descriptor
and detect any failure.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1915 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 14:33:49 +00:00
Jim Meyering
dba6cd0859 totemconfig: avoid a file descriptor leak in the common case
* exec/totemconfig.c (read_keyfile): Don't leak a file descriptor.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1914 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-30 14:33:42 +00:00
Steven Dake
e77b1e21ad Make all threads use same scheduling priority even with -p option
specified to avoid deadlock in spinlocks.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1912 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-25 18:25:18 +00:00
Christine Caulfield
200fe649c7 Fix IPC when running on mac OS/X
Note that OS/X seems to be rather stingy about its IPC resources, so if things
crash you will probably have to clean up before starting it all again.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1911 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-25 15:54:31 +00:00
Christine Caulfield
73a3bd206f The IPC system smply concatenates SOCKETDIR with run/<socketname> so if
th euser forgets to add a trailing slash to the name: eg

./configure --with-socket-dir=/var/run

then the socket is created as /var/runcorosync.ipc

This patch adds the slash into the name generation printf.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1910 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-25 15:38:56 +00:00
Steven Dake
1b1c0b657a Appears to fix compile errors on macosx.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1909 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-24 16:03:46 +00:00
Jim Meyering
6a327f134b Do not perform arithmetic on "void*" pointers.
* exec/vsf_ykd.c (ykd_deliver_fn): Do not perform "void*" arithmetic.
* services/votequorum.c (quorum_deliver_fn): Likewise.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1907 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-24 13:05:55 +00:00
Jim Meyering
596e49cd7e avoid 8 warnings
* exec/totemconfig.c (objdb_get_string): Make "key" const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1904 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-24 10:38:52 +00:00
Jim Meyering
4dacba719a avoid 13 warnings
* exec/mainconfig.c (objdb_get_string): Make "key" const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1902 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-24 10:38:26 +00:00
Jim Meyering
7b0973f3bc avoid 22 warnings
* exec/totemconfig.c (objdb_get_int): Make "key" const.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1901 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-24 10:38:13 +00:00
Fabio M. Di Nitto
aaf6948ae7 Fix 64bit alignment issue in totempg
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1889 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-22 18:35:06 +00:00
Steven Dake
c5fc824d7f Abstracted Shared Memory IPC library
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1885 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-22 15:28:54 +00:00
Fabio M. Di Nitto
031c02f589 - Every .c file should include "config.h" to get the right defines...
- services/Makefile.am: add include search paths for config.h

- include/corosync/cs_config.h.in exports LCRSODIR and SOCKETDIR

- tools/Makefile.am: drop -D defines for dirs that are now in
cs_config.h or config.h

- configure.ac: sanitize prefix and exec_prefix paths. Export DIRS in
*config.h

- lib/Makefile.am: : drop -D defines for dirs that are now in
cs_config.h or config.h. Add rule to build lcr_ifact.o or building from
lib/ fails miserably



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1877 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 12:58:53 +00:00
Steven Dake
683ed1edde Remove some unnecessary serializer functions.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1876 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 10:27:17 +00:00
Steven Dake
5eacc5df82 Don't clobber stack on strings with length of zero.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1874 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 10:20:19 +00:00
Fabio M. Di Nitto
bfdc2663c9 Fix logsys SONAME
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1870 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 05:21:17 +00:00
Steven Dake
4711f1e236 Serialize access to service engines.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1868 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 21:51:07 +00:00
Fabio M. Di Nitto
f335bd74aa Add missing uninstall-local targets and fix configuration intall target
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1866 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 10:17:50 +00:00
Fabio M. Di Nitto
6b59a57a0c More cleanup for distcheck to work
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1865 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 09:17:40 +00:00
Christine Caulfield
359fc86601 Add a dummy parameter to totemip_iface check so that it compiles on Darwin.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1864 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 08:37:10 +00:00
Fabio M. Di Nitto
cadfe03dd6 Fix more soname= at linking
Start fixing distcheck

White space cleanups


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1862 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 07:52:48 +00:00
Fabio M. Di Nitto
ae754092ca - tidy up whitespaces
- try to keep everything < 80 cols

- stop installing testing lcrso

- fix soname= invokation



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1861 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 18:37:03 +00:00
Fabio M. Di Nitto
2feb8f959c Add support for SOCKETDIR
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1856 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 10:46:19 +00:00
Fabio M. Di Nitto
e8f4a4c606 remove hardcoded /var and use localstatedir
instead.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1854 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 09:53:39 +00:00
Fabio M. Di Nitto
20e0336de5 configure.ac:
- Fix white space for --help.
 - Drop LCRSODIR as global and move it to local directory.

all */Makefile.am:
 - export -DDIRECTORY_NAME as required (for now only LCRSO and
SYSCONFDIR)

top level Makefile.am:
- drop hardcoded ETCDIR that is just wrong and use the configured one

*.c files around:
- drop hardcoded ETCDIR and use configured one.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1853 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 13:54:40 +00:00
Fabio M. Di Nitto
e8d5ae2510 Major configure.in/ac cleanup
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1849 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 11:01:50 +00:00
Fabio M. Di Nitto
3b6651b221 - remove --enable-static option as it is not required. This was a
leftover from gcc-2.x something time. corosync binary should always be
built dynamic.

- fix quorum_* target as it was missing the list of objects to be linked
in.. doh!

- fix object dependencies between TARGET, TARGET_OBJS and TARGET_SRC.
This also fixes the build/relink issues at install times that have been
noted before.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1847 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-13 08:26:56 +00:00
Steven Dake
1c098a5964 All integers received from objdb_get_int had invalid handle type.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1846 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-12 17:13:42 +00:00
Steven Dake
34583b8ef0 Use nocheck flagging on confchg iteration of handle ids.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1845 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-12 16:15:34 +00:00
Steven Dake
2b84d1075b Add handle checking to the hdb system.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1842 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:28:01 +00:00
Steven Dake
2a4c53dc1b Fix several errors in objdb notification handling, hdb_handle_t type
conversion errors, indentation, and do hdb_handle_put after instance 
data is used instead of before.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1841 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:09:04 +00:00
Steven Dake
072231129e Use hdb_handle_t for handle type in service.c.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1840 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:06:18 +00:00
Fabio M. Di Nitto
229c1837b5 Fix library linking
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1838 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 12:30:52 +00:00