Commit Graph

1728 Commits

Author SHA1 Message Date
Jim Meyering
4c90a7a218 avoid buffer overrun when there are more than 128 path entries
* lcr_ifact.c (PATH_LIST_SIZE): Define.
(path_list): Use it.
(ld_library_path_build): Don't store into path_list[path_list_entries]
if the counter is too large.
(ldso_path_build): Likewise.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1883 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-20 15:48:35 +00:00
Jim Meyering
4e1239b77e don't store (and later deref) NULL upon strdup failure
* lcr_ifact.c (ld_library_path_build, ldso_path_build):
Handle strdup failure.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1882 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-20 15:48:27 +00:00
Jim Meyering
bfebf7da19 don't segfault upon failed strdup
* sa-confdb.c (load_config): Handle out-of-memory.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1881 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-20 15:48:19 +00:00
Steven Dake
4e5089cb5c Revert last change which broke corosync.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1880 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-20 06:55:49 +00:00
Steven Dake
03a951e5e4 Reworked not to require stmt-after-decl support, plus another to fix a
bug that would arise when parsing more than 128 paths.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1879 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-20 00:01:18 +00:00
Steven Dake
d038f4c148 While looking at used of LCRSODIR, I saw an unchecked strdup.
That could lead to a NULL dereference.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1878 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 23:50:35 +00:00
Fabio M. Di Nitto
031c02f589 - Every .c file should include "config.h" to get the right defines...
- services/Makefile.am: add include search paths for config.h

- include/corosync/cs_config.h.in exports LCRSODIR and SOCKETDIR

- tools/Makefile.am: drop -D defines for dirs that are now in
cs_config.h or config.h

- configure.ac: sanitize prefix and exec_prefix paths. Export DIRS in
*config.h

- lib/Makefile.am: : drop -D defines for dirs that are now in
cs_config.h or config.h. Add rule to build lcr_ifact.o or building from
lib/ fails miserably



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1877 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 12:58:53 +00:00
Steven Dake
683ed1edde Remove some unnecessary serializer functions.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1876 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 10:27:17 +00:00
Steven Dake
06483f4900 Dont clobber stck on strings with length of zero.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1875 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 10:20:37 +00:00
Steven Dake
5eacc5df82 Don't clobber stack on strings with length of zero.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1874 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 10:20:19 +00:00
Steven Dake
6975136eb5 Updated TODO for corosync.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1873 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 09:56:39 +00:00
Fabio M. Di Nitto
539efd286e Fix corosync.pc installation
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1872 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 07:54:55 +00:00
Fabio M. Di Nitto
c236cfa496 Add missing libs from pkgconfig generation
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1871 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 05:41:23 +00:00
Fabio M. Di Nitto
bfdc2663c9 Fix logsys SONAME
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1870 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 05:21:17 +00:00
Fabio M. Di Nitto
da0e99097f Don't use EXTRA_DIST in install/uninstall
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1869 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-19 04:52:44 +00:00
Steven Dake
4711f1e236 Serialize access to service engines.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1868 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 21:51:07 +00:00
Steven Dake
9e9fe9d3e5 Fix coroapi.h header errors.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1867 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 21:28:50 +00:00
Fabio M. Di Nitto
f335bd74aa Add missing uninstall-local targets and fix configuration intall target
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1866 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 10:17:50 +00:00
Fabio M. Di Nitto
6b59a57a0c More cleanup for distcheck to work
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1865 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 09:17:40 +00:00
Christine Caulfield
359fc86601 Add a dummy parameter to totemip_iface check so that it compiles on Darwin.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1864 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 08:37:10 +00:00
Fabio M. Di Nitto
4a19ef8216 Fix DARWIN_OPTS expansion
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1863 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 08:30:25 +00:00
Fabio M. Di Nitto
cadfe03dd6 Fix more soname= at linking
Start fixing distcheck

White space cleanups


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1862 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-18 07:52:48 +00:00
Fabio M. Di Nitto
ae754092ca - tidy up whitespaces
- try to keep everything < 80 cols

- stop installing testing lcrso

- fix soname= invokation



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1861 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 18:37:03 +00:00
Fabio M. Di Nitto
17658c56e6 Fix doc stuff
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1860 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 13:25:12 +00:00
Fabio M. Di Nitto
59fc21352d Update index.html to reflect new changes in man/Makefile.am
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1859 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 13:06:56 +00:00
Fabio M. Di Nitto
471bbb68e5 Drop tarball name from AC_INIT as it confuses the hell out of what we need
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1858 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 12:44:47 +00:00
Fabio M. Di Nitto
6ce3b4e526 Fix the whole manpage stuff
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1857 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 12:43:41 +00:00
Fabio M. Di Nitto
2feb8f959c Add support for SOCKETDIR
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1856 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 10:46:19 +00:00
Fabio M. Di Nitto
38a7a8f973 Add corosync.pc support
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1855 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 10:03:18 +00:00
Fabio M. Di Nitto
e8f4a4c606 remove hardcoded /var and use localstatedir
instead.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1854 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-17 09:53:39 +00:00
Fabio M. Di Nitto
20e0336de5 configure.ac:
- Fix white space for --help.
 - Drop LCRSODIR as global and move it to local directory.

all */Makefile.am:
 - export -DDIRECTORY_NAME as required (for now only LCRSO and
SYSCONFDIR)

top level Makefile.am:
- drop hardcoded ETCDIR that is just wrong and use the configured one

*.c files around:
- drop hardcoded ETCDIR and use configured one.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1853 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 13:54:40 +00:00
Fabio M. Di Nitto
14a1780f5d Fix LCRSO handling
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1852 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 13:15:25 +00:00
Fabio M. Di Nitto
0641498a34 Make everything < 80 cols
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1851 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 11:50:19 +00:00
Fabio M. Di Nitto
9ea71412d8 remove comment
fix quoting

make GCC test portable


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1850 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 11:36:49 +00:00
Fabio M. Di Nitto
e8d5ae2510 Major configure.in/ac cleanup
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1849 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-16 11:01:50 +00:00
Fabio M. Di Nitto
081c3ed430 - Fix macro typo for PROG_CC_C_O.
- add --enable-debug configure option to #define DEBUG 1 and set
compiler options to default to -O0.

- restore default -O3.

- Drop some random leftovers (CC_IN_CONFIGURE, AISPREFIX, SSH path check
and ppc64 -m64).

- Remove yet another GCC test as -g is automatically detected by
autoconf macros.

- Cleanup a bit deprecated ARCH section.

- Tidy up RESULT section.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1848 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-13 10:02:09 +00:00
Fabio M. Di Nitto
3b6651b221 - remove --enable-static option as it is not required. This was a
leftover from gcc-2.x something time. corosync binary should always be
built dynamic.

- fix quorum_* target as it was missing the list of objects to be linked
in.. doh!

- fix object dependencies between TARGET, TARGET_OBJS and TARGET_SRC.
This also fixes the build/relink issues at install times that have been
noted before.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1847 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-13 08:26:56 +00:00
Steven Dake
1c098a5964 All integers received from objdb_get_int had invalid handle type.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1846 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-12 17:13:42 +00:00
Steven Dake
34583b8ef0 Use nocheck flagging on confchg iteration of handle ids.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1845 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-12 16:15:34 +00:00
Christine Caulfield
927921109c Fix testconfdb use of object handles.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1844 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-12 14:30:58 +00:00
Steven Dake
2db2ef76a8 Set correct OBJECT_PARENT_HANDLE define in coroapi.h
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1843 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:48:05 +00:00
Steven Dake
2b84d1075b Add handle checking to the hdb system.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1842 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:28:01 +00:00
Steven Dake
2a4c53dc1b Fix several errors in objdb notification handling, hdb_handle_t type
conversion errors, indentation, and do hdb_handle_put after instance 
data is used instead of before.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1841 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:09:04 +00:00
Steven Dake
072231129e Use hdb_handle_t for handle type in service.c.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1840 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:06:18 +00:00
Steven Dake
0c1eb7cb1d Use hdb_handle_t for handle type in lcr_ifact.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1839 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 23:05:41 +00:00
Fabio M. Di Nitto
229c1837b5 Fix library linking
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1838 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 12:30:52 +00:00
Fabio M. Di Nitto
0e4f5a04c7 Fix more build/install glitches
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1837 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 11:33:19 +00:00
Steven Dake
1c52564bbd Fix broken error check in commit 1818.
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1836 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 11:27:20 +00:00
Fabio M. Di Nitto
00731ff68b 1) kill all those "for" shell loops. They are dangerous (as they don't
report install failures) and it's just overhead since $(INSTALL) can do
the same.

2) make sure to create our directories with $(INSTALL). Not sure I did
catch them all yet, but at least a good bunch. This also fix the
corosync.conf install error I introduced in the previous commit.

3) Handle SONAME automatically. This is the most intrusive change across
the board:

 * configure.in now defines the system wide SOMAJOR, SOMINOR, SOMICRO
and SONAME and exports them to the Makefile.
 * exec/Makefile.am, lib/Makefile.am are now updated to use those vars
rather than hardcoded version.

4) Bump the SOMAJOR to 3 as agreed since we did change both API and ABI.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1835 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 09:06:35 +00:00
Fabio M. Di Nitto
76c5969b1e Dear pacemaker.. you will not take over this project! MUAHAH
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@1834 fd59a12c-fef9-0310-b244-a6a79926bd2f
2009-03-11 08:03:55 +00:00