proxmox-mirrors/mirror_corosync
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_corosync synced 2026-01-28 06:07:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,700 Commits 1 Branch 64 Tags 16 MiB
783dd4e553
Commit Graph

1392 Commits

Author SHA1 Message Date
Steven Dake
b8af7c3764 sem_wait can be interrupted by signal. Handle interruption properly. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2920 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-06-03 22:05:17 +00:00
Steven Dake
22471e113d Fix fail to receive logic which occurs very rarely on high loss networks with 
software based multicast.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2919 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-06-03 21:36:21 +00:00
Steven Dake
79c60fd0ad Totem spec is clear: 
reject retransmitted tokens
if token.aru = aru in token on last rotation ... do some logic

Here is how the current code works:

last_aru = instance->my_last_aru;
instance->my_last_aru = token->aru;
reject retransmitted tokens
if token.aru = aru in token on last rotation ... do some logic

The issue is last_aru will be set to token->aru when a token retransmission
occurs before a new token arrives.

This results in the "do some logic" part happening more often then it should.    


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2917 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-06-01 20:35:53 +00:00
Steven Dake
c3a6b98bdc The static function 'decode_mode()' is used by the static function 
'dump_subsys_config()' which is is turn used by the static function
'dump_full_config()' which is never used.

Are these functions used by someone using some magic? I did not find
any reference and even the flag LOGSYS_DEBUG, which prevents them from
compiling, does not exist at some other point.

If these functions are really not used, please remove them (because at
least one of them has a buffer overflow). Patch against 1.2.3
is attached.

If there is a need for these functions, I'll send a patch to fix
the 'decode_mode()' function.

Kind regards

Andreas Florath

Signed-off-by: Andreas Florath <gnu4u at flonatel dot org>



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2915 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-28 20:39:58 +00:00
Steven Dake
4561c6dcf6 Fix problem where memcpy operation occurs incorrectly to copy schedule 
parameter data resulting in priority inversion deadlocks on single cpu systems.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2906 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-26 17:47:39 +00:00
Steven Dake
d209f7bb27 Fix leak in error path in nss encryption. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2857 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-19 05:30:18 +00:00
Angus Salkeld
7999995273 cov 10412: fix mem leak in encrypt_and_sign_nss() 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2854 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-19 04:35:25 +00:00
Angus Salkeld
4ff33854ad add __attribute__((noreturn)) to functions that always exit. 
we had some __attribute__((__noreturn__))
and some    __attribute__((noreturn))

I made them all: __attribute__((noreturn))



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2853 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-19 04:34:53 +00:00
Steven Dake
6d79a218e2 Fix signed comparison with unsigned value in mainconfig.c 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2851 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 16:44:59 +00:00
Angus Salkeld
0c790c067a cov 10388: fix check for no mcast address 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2850 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:46:35 +00:00
Angus Salkeld
ad71b66c7b cov (many): make sure all _set() functions return a signed int 
in the body it can return -1, and callers check for -1.
but the return type is unsigned int?



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2849 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:46:08 +00:00
Angus Salkeld
2a23dfc585 cov 10391: allow assert to check for a negative number 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2848 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:43:41 +00:00
Angus Salkeld
8236a0873e cov 10404: don't assign loc pointer when not used. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2847 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:14:02 +00:00
Steven Dake
d4f92c864a Fix problem where logsys messages are not flushed at exit before worker thread 
is created.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2846 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:13:54 +00:00
Angus Salkeld
92985c31d9 cov 10405: remove unused pointer from totemsrp. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2845 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-18 00:12:52 +00:00
Angus Salkeld
18326ad242 cov 10392: remove pointless assert 
backlog is unsigned



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2842 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:40:19 +00:00
Angus Salkeld
71a09466e4 cov 10413: crypto init a variable. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2841 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:36:51 +00:00
Angus Salkeld
b2a304d8f8 cov (10387, 10397): cleanup memory mapping functions 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2840 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:35:52 +00:00
Angus Salkeld
d08c6d577f cov 10399: set the msg_flags to 0 in coroipcs. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2838 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:33:32 +00:00
Angus Salkeld
43d4f9d040 cov 10389: remove unneccessary check. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2836 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:31:28 +00:00
Angus Salkeld
2f21e126be cov 10371: check return of lcr_ifact_reference 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2835 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:29:30 +00:00
Angus Salkeld
5eba844916 cov 10401: error_string never set 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2834 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:28:13 +00:00
Angus Salkeld
202de1b8e2 cov 10411: fix leak in totemudp.c 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2833 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:26:15 +00:00
Angus Salkeld
ff8d0084cb cov 10400: unit'ed variable. 
not important, easy to fix.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2832 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-16 21:25:33 +00:00
Angus Salkeld
45152f0902 cov 10378: fix syntax error. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2829 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-14 02:08:02 +00:00
Angus Salkeld
3eb76c2154 cov 10382: improve error handling around open() 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2825 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-14 02:05:32 +00:00
Angus Salkeld
b4f61842b6 cov 10381: check result of open() 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2824 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-14 02:04:53 +00:00
Angus Salkeld
3ebd6fab52 cov 10379 &10380: check result of open before calling ftruncate. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2823 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-14 02:03:49 +00:00
Steven Dake
5e8f1a730f logsys rework to deal with memory corruption around debug:on configurations. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2816 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-13 04:36:42 +00:00
Angus Salkeld
6bae61d835 log: remove "Member left/join" log messages 
No longer needed by CTS and likely to be very noisy
with large node numbers.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2804 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-05 04:36:56 +00:00
Angus Salkeld
ea345ef0fd check and discard unknown messages 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2800 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-04 04:25:31 +00:00
Angus Salkeld
8ebe03efd5 diags: add a mechanism to trigger the writing the flight data 
trigger the dumping of flight data using:
 corosync-objctl -w runtime.blackbox.dump_flight_data=anything
trigger the dumping of state using:
 corosync-objctl -w runtime.blackbox.dump_state=anything

then read the flight data as usual:
 corosync-fplay

This patch includes a wrapper script called:
 corosync-blackbox



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2799 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-05-04 00:56:25 +00:00
Steven Dake
5672c3efa8 The retransmit token storage area is an improper type of an array of pointers 
rather then a pointer to a buffer.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2795 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-30 05:18:02 +00:00
Steven Dake
005b9af59d When a message is retransmitted, a memmove operation is done to remove the 
newly retransmitted entry from the list.  It is possible this memmove operation
can buffer overflow because it has an invalid length calculation fixed by this
revision.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2794 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-30 05:15:41 +00:00
Steven Dake
80d621e25f Allow maximum entries in the retransmit queue when recovery takes place. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2793 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-30 05:14:08 +00:00
Steven Dake
107ef19913 Save the ring id and restore it properly when the recovery operation fails as 
a result of a new gather or token loss.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2792 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-30 05:12:26 +00:00
Jan Friesse
12c5f31a89 Handle some valgrind errors 
- Memset for res_setup variable in coroipcs:req_setup_send
- Two memset in logsys for buffers
- Problem in corosync_totem_stats_updater where avg_token_holdtime has
size of avg_backlog_calc
- corosync_totem_stats_init where avg_backlog_calc is 32 bits (not 64)
- objdb problem if new_valie_len != object->value_len. In such case
newly allocated memory is not initialized and in some situations,
value_len is not updated.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2787 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-23 08:03:05 +00:00
Christine Caulfield
e88c09e7c2 Fix a crash in YKD 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2767 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-20 07:27:14 +00:00
Angus Salkeld
212126fa34 When sync is aborted clear the "my_ring_id" variable. 
This patch fixes crashes found by repeated pacemaker CTS SimluStart
tests. When you bring up the nodes together it can cause a lot of
configuration changes and sync gets started and aborted
lots of times.

When abort is called the ring_id is not changed which means that any
sync packet that arrive from that point on will be accepted as valid.
I have seen old barrier messages causing the processing index to increment
later causing an array out of bounds.

This patch memsets the ring_id to 0, thus causing the ring_id in the packet and
my_ring_id not to match.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2757 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-12 19:51:38 +00:00
Steven Dake
97174868b1 Allow modifying POLLIN/POLLOUT state in another thread while the main thread 
is blocked in poll system call.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2755 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-04-02 19:16:23 +00:00
Steven Dake
cf4e2069b6 Fix barrier operation with syncv2 and compat:none or openais service engines. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2750 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-30 08:23:10 +00:00
Angus Salkeld
805a0f3c1d objdb: fix key change notifications 
1) don't send notifications if the key is the same.
2) Add key value change notifications to key_inc & key_dec



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2746 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-30 07:19:25 +00:00
Jrme Flesch
a5f2733211 Totemudp: Add debug logs when a call to sendmsg() fails 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2740 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-26 13:54:42 +00:00
Angus Salkeld
49ef3eb196 Make corosync exit with 0 normally and +1.. on error. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2739 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-25 00:58:14 +00:00
Angus Salkeld
59826dd14e Fix unloading of evs (service id == 0) 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2731 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-24 22:16:32 +00:00
Angus Salkeld
9a862803aa Fix code coverage with lcrso's 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2729 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-24 22:14:25 +00:00
Steven Dake
64d60a26c6 Tone down noisy logging from ipcs system. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2721 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-23 17:16:39 +00:00
Steven Dake
2cc62fdd34 Fix lockup that occurs rarely with pthread_join() is called in atexit() 
handler.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2719 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-22 22:07:01 +00:00
Steven Dake
084d19cddc Fix problem where retransmissions don't occur resulting in failure to receive 
condition.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2685 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-20 20:08:38 +00:00
Christine Caulfield
576614109e Fix a couple of small bugs that happen when the configuration is reloaded. 
1. the reload callback was not sent to the library,
2. totem exponentially added new callbacks because the old ones were not
   removed properly.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2684 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-16 09:53:18 +00:00
Angus Salkeld
ce492d7008 add a list of member nodes into the objdb runtime tree. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2678 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-09 22:04:06 +00:00
Angus Salkeld
92ade89db6 tsafe: change fork() override to pthread_atfork() callbacks. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2677 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-09 21:59:24 +00:00
Angus Salkeld
ec09a97867 Fix some "make lint" problems 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2674 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-03 21:52:08 +00:00
Angus Salkeld
4a14c93fcb Add tsafe.h to noinst_HEADERS to fix "make distcheck" 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2670 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-03 04:51:43 +00:00
Angus Salkeld
4e7ded5bf3 Add tsafe (thread safe) file to catch unsafe function calls. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2669 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-03 01:27:37 +00:00
Angus Salkeld
824fd8e82a Add a test harness to corosync that uses CTS from pacemaker. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2668 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-03-03 00:08:57 +00:00
Christine Caulfield
e9adc51893 Reduce the number of times the quorum message is displayed. 
Patch from David Teigland



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2667 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-26 15:30:38 +00:00
Angus Salkeld
efd0157b39 convert giduid calls to reentrant versions. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2666 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-25 19:29:49 +00:00
Angus Salkeld
20f3331d0e convert strerror() into strerror_r() 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2665 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-25 19:28:36 +00:00
Angus Salkeld
2290913d28 convert readdir into readdir_r 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2664 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-25 19:26:54 +00:00
Angus Salkeld
5dd31150ee convert strtok to strtok_r 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2663 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-25 19:25:20 +00:00
Angus Salkeld
fdeea0b3b1 Add a debug message on node join/leave. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2662 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-18 20:12:14 +00:00
Steven Dake
bc64fbcb58 Patch to set unset value in token hold cancel structure as to not crash 
wireshark.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2660 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-18 20:08:39 +00:00
Jan Friesse
5a8200c1cb Fix corosync shutdown process 
This patch change corosync shutdown process, so now:
- exit function of service engine is called
- all IPC connections are closed and removed from poll
- service engine is unlocked


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2657 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-16 11:29:14 +00:00
Steven Dake
1978c9d471 Use nodeid instead of localhost ip for the case when binding to a 
loalhost interface.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2656 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-15 21:39:33 +00:00
Steven Dake
a1bf354ed4 Merge of Dejan's on=yes patch for the config parser options to ease migration. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2654 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-04 21:36:21 +00:00
Angus Salkeld
c6beee076a pass transitional members into the sync_init() callbacks. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2653 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-04 00:18:51 +00:00
Angus Salkeld
e88aebbac7 move sync_v2_init() into main_service_ready 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2652 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-04 00:13:27 +00:00
Angus Salkeld
8671945cef totemsrp: fix transitional configuration changes with long token timeouts 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2651 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-02-02 06:24:01 +00:00
Steven Dake
2f24513d87 Fix coroipcs message corruption that occurs when a message fills the remainder 
of the dispatch buffer with a full message.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2650 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-30 23:02:40 +00:00
Jan Friesse
f4a644c711 Add schedwrk_create_nolock function 
This patch adds schedwrk_create_nolock, which will not call
serialize_lock before execution of callback.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2649 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-22 09:45:29 +00:00
Jan Friesse
5524a4738a Pass correct poll handle to poll_stop on exit 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2648 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-21 12:48:30 +00:00
Jan Friesse
68d7e86c2f poll_dispatch_delete - ability to return 0 
Patch fixes poll_dispatch_delete, so it is able to return 0
(success), when requested FD was found.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2647 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-21 12:46:09 +00:00
Jan Friesse
c9baa674f5 Fix setting invalid mode in log destination 
This fixes problem in revision 2642, when only last
line of log destination setting is really applied.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2646 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-20 13:22:38 +00:00
Jan Friesse
64c6c6f324 Fix malloc deadlock in signal handler 
This patch solves situations, where malloc is called 
inside signal handler. It creates thread, which waits
for semaphore unlock and then starts shutdown sequence.

RHBZ#547511


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2644 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-14 12:54:46 +00:00
Jan Friesse
99db356765 Fix coroparse to allow white chars before comment 
- allows white characters before #
- new function to parse log destinations (remove code duplicity)
- clarify man page


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2642 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-13 09:52:07 +00:00
Jan Friesse
4d2e24a2c3 Generate nodeid value when unset on BSD 
Generated nodeid is generated in same way as
on Linux is.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2641 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2010-01-11 10:12:17 +00:00
Steven Dake
dc2a0e68d6 Remove invalid assertion in totemsrp. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2640 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-15 19:22:36 +00:00
Angus Salkeld
ec6e57dd42 Allow empty (default) consensus timeout. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2638 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-08 07:48:53 +00:00
Steven Dake
208d907f63 Remove string overwrite if many recovery messages are originated. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2580 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-08 00:01:39 +00:00
Steven Dake
c0883b4469 Remove compiler warning in vsf_quorum.c. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2579 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 23:23:42 +00:00
Steven Dake
f434e74faa Remove compiler warning in totemsrp. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2578 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 23:21:01 +00:00
Steven Dake
b4367e6075 Set boolean indicating the retrans flag was set to 1 to 0 when setting retrans 
flag in token to zero.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2573 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 18:41:49 +00:00
Steven Dake
ff5cd7d57c Make assertions for range checking of message delivery check with the define 
instead of magic numbers that are not valid if the define changes.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2572 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 18:22:48 +00:00
Jan Friesse
c6242c9a52 Remove potentially thread unsafe call of strftime 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2571 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 17:14:44 +00:00
Steven Dake
adf8d6db24 Prevent lockup in recovery state in totem after 206 messages are originated. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2569 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 05:03:25 +00:00
Steven Dake
3020fd5742 Fix recovery messages to be proper length to remove segfault that occurs during 
recovery.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2568 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-07 05:02:28 +00:00
Steven Dake
b3e19b2905 Force consensus timer to be at minimum 1.2 * token to prevent one group of 
nodes from executing a token timeout in the COMMIT state while another node
executes a consensus timeout, showing to applications as a temporary network
partition.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2567 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-06 01:35:05 +00:00
Christine Caulfield
2e2581f574 This puts multiple nodeids on each [QUORUM] Members line instead of 
putting each nodeid on a separate line.  With more than a few nodes the
excessive lines become a real nuisance, and anyone up around 32 nodes
may literally be scrolling through hundreds of those lines.

from David teigland



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2565 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-04 16:10:59 +00:00
Angus Salkeld
c052bd3f3f stats: don't calloc the totemsrp stats struct. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2564 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-03 18:18:29 +00:00
Angus Salkeld
acf9a8d85f Correct some ugly indentation. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2563 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-03 18:13:52 +00:00
Angus Salkeld
b63c2c27b6 objdb: fix memory leaks when objects are destroyed. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2562 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-03 08:36:31 +00:00
Angus Salkeld
663f894498 make sure key_names past from confdb are null terminated. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2561 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-02 22:14:00 +00:00
Jan Friesse
9edbf61401 bsd: Fix mlockall on FreeBSD version >= 8.0 
FreeBSD version 8.0 and greater supports mlockall
syscall correctly. So configure.ac is changed to detect
FreeBSD version and main.c is changed to support it.

Resolves: rhbz#513687


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2560 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-12-02 15:09:18 +00:00
Fabio M. Di Nitto
398a381965 Fix threads vs fork init order 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2558 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-30 23:01:51 +00:00
Steven Dake
72fe262478 Start pause timer at initialization so first gather doesn't result in pause 
timeout operations.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2555 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-30 19:11:20 +00:00
Angus Salkeld
29eb20a389 Rename totem_new_msg_signal() to something more generic. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2553 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-29 18:42:00 +00:00
Angus Salkeld
27d383276b coroipcs: Add a queue_size stats counter to each ipc connection. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2552 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-29 18:28:39 +00:00
Angus Salkeld
ce8046f353 coroipcs: add logging for flow control state changes. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2551 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-29 18:25:51 +00:00
Steven Dake
ee226d0730 Patch to use proper IFA on Linux platforms to match interface addresses when 
netmask is not 255.255.255.0.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2550 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-27 22:59:48 +00:00
Angus Salkeld
34ddb1cb14 COVERITY 12: prevent overrun of logsys output buffers. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2547 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-22 23:19:41 +00:00
Angus Salkeld
e5b94a352e COVERITY 14: free zcb_mapped if memory_map() fails. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2544 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-11-22 06:27:09 +00:00
Steven Dake
6ea4afe60f Revert commit 2523 which results in segfaults under some workloads. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2536 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-22 22:29:02 +00:00
Steven Dake
60e406f355 Resolve shutdown problems for pacemaker use case. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2531 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-20 21:07:50 +00:00
Angus Salkeld
07072bd0b1 Add a log_printf function to coroipcs so we can pass the log level 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2530 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-18 18:15:24 +00:00
Angus Salkeld
494bf45ebf Avoid array out of bound error. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2529 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-14 23:05:18 +00:00
Steven Dake
765fa65351 Patch from jflesch to fix segfault when using sysv semaphores that the thread 
state is checked prior to the semaphore operation, not after it has completed.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2524 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-14 19:06:37 +00:00
Steven Dake
59ecd3ad4a totem process group optimization to not copy data into staging buffer if 
it is to be immediately ordered by totemsrp.  Instead pass that data as an
iovector element.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2523 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-14 18:56:54 +00:00
Angus Salkeld
49345f48f8 stats: prevent a div by zero if totem_count is zero. 
patch by Chrissie



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2522 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-14 04:06:42 +00:00
Angus Salkeld
97ed934966 Fix the OSX build (broken by stats patches) 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2521 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-13 08:13:53 +00:00
Andrew Beekhof
4fba207d42 Add SIGTERM support and have the init script wait for corosync to actually terminate. Bud rh#525552 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2520 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-13 06:16:14 +00:00
Angus Salkeld
948ca19aa7 Add some missing calls to increment the relevant stats. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2519 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-12 21:56:23 +00:00
Angus Salkeld
4e6e33467d allow coroipcs to work without calling stats initialization. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2518 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-12 21:50:10 +00:00
Angus Salkeld
73a24c0352 Add totem stats to objdb. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2517 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-12 17:30:20 +00:00
Angus Salkeld
f78e719713 Add per service-function statistics. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2515 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-12 00:39:39 +00:00
Angus Salkeld
afbbc5e5ff Add connection related statistics to the object db. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2514 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-12 00:36:55 +00:00
Angus Salkeld
e66297a886 Test the key value size for typed keys. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2513 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-11 23:46:07 +00:00
Angus Salkeld
0c9a6c49ff teach object_key_increment() key types. 
This is so we can increment all integer types correctly.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2512 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-11 22:53:13 +00:00
Angus Salkeld
73b7aa19bb Add value types to objdb keys. 
This allows you to create a key with a know type.
And then get the type with the key value.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2511 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-10 03:20:38 +00:00
Christine Caulfield
2433ee3b2c This patche fixes a couple of small problems with votequorum: 
- if a single node is booted with votequorum loaded then
   corosync-quorumtool shows zero nodes and no votes.
- votequorum doesn't always tell the main quorum module when a new node 
has joined the cluster (principally itself. this bug is actually tied 
into the above)

I've also added quorum to the default list of services. As quorum has 
been decoupled from sync it will not interfere with normal operations as 
it used to do and it makes more sense to have it there than not.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2510 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-10-06 12:57:35 +00:00
Steven Dake
978b60806b Totem IBA implementation. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2481 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-25 06:23:04 +00:00
Steven Dake
6ad014a315 make main_service_ready function static. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2480 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-25 06:06:31 +00:00
Steven Dake
6ae6f6e284 Fix abort with multiple cpg clients under heavy load. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2467 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-21 18:27:37 +00:00
Steven Dake
60d50de816 Remove warning in logsys compile related to const correctness. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2463 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-20 06:56:02 +00:00
Steven Dake
215ad336f2 Fix sigpipe handling to ignore sigpipes on systems which support them. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2419 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-20 05:36:52 +00:00
Steven Dake
eb5fa99cae Make delete operation work properly in coropoll. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2418 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-20 05:34:41 +00:00
Angus Salkeld
350cc0ae42 log the built-in features at startup 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2411 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-10 01:51:32 +00:00
Angus Salkeld
147c81ffab don't return the ip address when the mask is not found 
Currently totemip_copy (boundto,&ipaddr) is called even when the
required mask is not found.

This patch changes the behavior to only copy the ipaddr when the
mask is found.

The current behavior makes debugging an incorrect config really
confusing.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2409 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-09 18:55:17 +00:00
Angus Salkeld
f3b92eb6b3 Only insert the filename into the log, not the path. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2408 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-09 00:25:36 +00:00
Fabio M. Di Nitto
3ffb151aa7 Fix missing symbol error when loading plugins without executive 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2405 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-07 10:41:42 +00:00
Angus Salkeld
e1ceabc6ef Remove a double unlock in logsys. 
In logsys there are a number of XYZ_unlocked() functions that are called
like this:

       pthread_mutex_lock (&logsys_config_mutex);

       XYZ_unlocked();

       pthread_mutex_unlock (&logsys_config_mutex);

The XYZ_unlocked() functions should not do any (un)locking.
But _logsys_config_subsys_get_unlocked() unlocks if it finds the subsys.
This means that there is 1 lock and 2 unlocks.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2404 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-07 08:33:23 +00:00
Christine Caulfield
898790d501 Return CS_ERR_NOT_EXIST if a client tries to contact a plugin that isn't loaded. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2403 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-09-07 07:28:25 +00:00
Steven Dake
519616de0c Fix off by one calculation error resulting in assertion. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2398 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-28 18:20:14 +00:00
Christine Caulfield
21fedb2495 Send CURRENT callbacks to the dispatch FD rather than the callback one. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2397 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-28 09:36:33 +00:00
Steven Dake
21825d46ea Fix incorrect assertion with frame sizes of 9000. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2395 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-28 01:19:30 +00:00
Jan Friesse
d11f1f90c2 Fix found_service_ver handling 
Sometimes, when object_key_get doesn't return found_service_ver it
doesn't change old value and this value is then used in atoi what
will can cause fall of corosync. Patch fixes this case by setting
found_service_ver to NULL before call of object_key_get.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2391 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-19 09:57:28 +00:00
Jan Friesse
55db0b67a2 Fix systems without _POSIX_THREAD_PROCESS_SHARED 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2390 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-19 09:55:49 +00:00
Steven Dake
f558917703 Proper limits checking for message sizes to allow ~1mb max message sizes for corosync. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2388 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-17 18:22:11 +00:00
Fabio M. Di Nitto
13f3c5bc6a Delay forking and closing of fds as much as possible 
to allow startup wrappers (such as cman_tool) to collect
as much errors as possible in case of startup failure



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2385 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-12 06:57:53 +00:00
Fabio M. Di Nitto
498f24fa32 corosync: move logsys thread config with all the others 
logsys thread priority was configured after forking the
wthread process and spread the scheduler priority config
across a large chunk of code in main.c

Now that logsys scheduler priority can be invoked at any time,
move the code together with corosync_setscheduler code.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2383 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-10 05:39:45 +00:00
Fabio M. Di Nitto
6115c85328 logsys: fix segfault in logsys_thread_priority_set 
logsys_thread_priority_set expects that wthread is already running
but doesn't perform any check if it is.

if logsys_thread_priority_set is invoked before forking the thread,
a segfault is guaranteed.

this changes to logsys_thread_priority_set ensure that a request
for a new scheduler priority is queued if the wthread is not
created yet and the new scheduler parameters are applied as early
as possible after the thread is created.

At the same time:

- add a few comments on clean up that needs to be done
- remove a redundant check for policy != SCHED_OTHER as that's
  corosync need specific. logsys should simply accept the request
  and apply it.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2382 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-10 05:32:58 +00:00
Jan Friesse
9931d50b31 Support for -v (version) feature 
This can be usefull for easier way to get informations
of the corosync version from users. Version and SVN
revision (get by svninfo -c) are displayed.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2381 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-04 07:39:03 +00:00
Christine Caulfield
27b55337ce This patch makes a copy of the notifications list before calling the 
reload_notifications callbacks. This allows callback functions to 
manipulate the notifications list without causing corruption or strange 
loops.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2380 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-04 07:14:55 +00:00
Steven Dake
ee7ce5e328 Use unnamed shared posix semaphores on platforms which support them. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2379 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-04 00:22:41 +00:00
Steven Dake
4e3e77eb13 Always keep autogenerated node ids in totem as LE even on BE arches. 
Have testcpg print out autogenerated nodeid properly on BE arch.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2377 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-04 00:04:13 +00:00
Jan Friesse
2ef1853fe2 Support for systems where clock_gettime is not available 
On some systems clock_gettime is not available so we are
testing availability and value of _POSIX_MONOTONIC_CLOCK.

On system without support of clock_gettime, we are using
old behaviour with function gettimeofday.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2376 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-08-03 08:11:53 +00:00
Jan Friesse
c50a6bd065 Support for monotime timer 
This patch should solve problems with corosync and ntp, by using
clock_gettime where it make sense.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2373 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-27 10:12:55 +00:00
Steven Dake
69928e301a Add notification when totem has completed initialization. 
This triggers the initialization of the service engines which may need totem
for initialization.



git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2372 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-27 02:00:05 +00:00
Steven Dake
f9f663f459 Add a target token set completed callback in totemrrp and below layers. 
Handle management of callback in totemsrp.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2371 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-27 00:29:32 +00:00
Jan Friesse
a1db33fc99 Handle NULL ver string in service 
In case user not enter ver: in service section, whole
corosync falled with segfaul, because atoi was called
on NULL.

Now, in case of NULL, we rather not use atoi, and
return 0 directly.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2370 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-23 14:50:56 +00:00
Steven Dake
5eae4c135c Optimization of totemsrp and below by removing hdb usage. cpgbench shows 
results of 4% to 20% increase in tps and mbs depending on hardware.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2369 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-22 22:10:35 +00:00
Jan Friesse
996850db39 Support for service.d 
This patch is very similar to uidgid.d patch, but support for loading
services (so read service section).


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2368 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-22 08:25:45 +00:00
Steven Dake
5225b3809c Initial infrastructure changes to support iba. Split totemnet into 
totemiba and totemudp and have totemnet call the appropriate transport
calls.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2367 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-21 18:17:15 +00:00
Steven Dake
279e297842 Darwin is missing the sched_setscheduler system call. 
Patch detects it and resolves the build failure.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2366 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-21 01:31:39 +00:00
Jrme Flesch
483fe491f9 BSD support: Fix EOF handling in coroipcs.c:req_setup_recv() and coroipcs:coroipcs_handler_dispatch() 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2345 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-02 07:47:04 +00:00
Steven Dake
176d80eafe Set version field in totem header in case it isn't set by default. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2340 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-01 20:29:55 +00:00
Steven Dake
c12253097f Send ERR_SECURITY when invalid security context is provided via ipc clients. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2338 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-01 20:04:20 +00:00
Steven Dake
7954f19ac3 Fix build on bsd systems. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2336 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-01 19:55:18 +00:00
Steven Dake
c5bccf1a7a Align syncv2 on 8 byte boundaries. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2335 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-01 19:48:14 +00:00
Steven Dake
9a2b66df63 Make compatibility mode none work properly. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2334 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-07-01 19:37:59 +00:00
Jim Meyering
4f1aabe431 remove unnecessary #include 
* exec/evil.c: Don't include <signal.h>.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2323 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-30 09:27:27 +00:00
Jim Meyering
6aad39be63 remove trailing blanks 
* corosync.spec.in:
* exec/evil.c:
* exec/main.c:
* exec/mainconfig.c:
* exec/syncv2.c:

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2322 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-30 09:27:20 +00:00
Steven Dake
15d2c48963 Export poll handle via coroapi.h. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2318 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-29 23:24:24 +00:00
Steven Dake
2b31a4d94b Static-ize some main.c variables. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2316 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 06:03:06 +00:00
Steven Dake
fc2de3db2a Simplify notifications from totem at the notice level. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2315 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 05:26:25 +00:00
Steven Dake
56dbf70bb1 Remove hard coded sync values and use defines from coroapi.h. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2314 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 05:21:14 +00:00
Steven Dake
23aea08ae4 Slay the debug messages coming out at notice level in totem. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2313 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 05:12:27 +00:00
Steven Dake
47c6bc3aaf Remove totemsrp warning. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2312 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 04:57:31 +00:00
Steven Dake
18a19bac27 Allow syncv2 to determine membership list when run in compatibility mode. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2311 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 04:51:38 +00:00
Steven Dake
1cdd0f5fab Follow synchronization model of event service so corosync without openais 
service engines can communicate with the openais whitetank event service
in compatibility mode.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2310 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 04:50:18 +00:00
Steven Dake
654810365b Send fake barriers for the event service when operating in compatibility mode 
whitetank.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2309 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-28 00:16:54 +00:00
Steven Dake
bbd880ec47 Remove some debug printfs that snuck in. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2306 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-27 02:06:20 +00:00
Steven Dake
e1b054ae0a Change sync_init api call to pass information relevant for making 
synchronization decisions.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2305 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-27 01:59:59 +00:00
Steven Dake
e448603f2f Add ability to detect process pause and not implode the membership algorithm 
when this occurs.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2304 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-26 21:39:44 +00:00
Steven Dake
621511d336 Add syncv2. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2302 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-26 21:15:19 +00:00
Steven Dake
547342d77d Fix build error in evil.c 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2300 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-26 01:20:06 +00:00
Steven Dake
0ca0773904 Fix no boottime support warning. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2299 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-26 00:53:43 +00:00
Steven Dake
f540be9060 Add compatability option in config file. Defaults to whitetank. 
Add sync_mode to coroapi to indicate to corosync the service engine's
desired compatibility mode.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2298 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-26 00:25:52 +00:00
Steven Dake
2c3836d8fa sync-v1 onwire compat layer for raw corosync to communicate with whitetank. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2296 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-25 22:07:26 +00:00
Steven Dake
54fefe152d Remove totempg debug message. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2289 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-24 05:21:13 +00:00
Steven Dake
5780b2b660 Add assembly to free list when it is removed from a configuration change as 
indicated by being in the left list.

This has side effect of clearing the assembly buffer the next time it is
referenced from the free list.  This fixes a defect that stops forward
processing of the message streams because sync fails to finish when receiving
a sync message from a restarted processor because it throws away the message.




git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2288 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-24 01:01:57 +00:00
Steven Dake
8c677d1103 Tidy's up startup printfs. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2286 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-23 17:09:24 +00:00
Steven Dake
defbffd3a6 Change startup notice to Corosync Cluster Engine. 
Change 2008 to 2009 in copyright.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2285 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-23 05:53:05 +00:00
Steven Dake
808cd8c410 Remove "AIS" string from exit notice. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2284 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-23 05:50:04 +00:00
Steven Dake
cd564ca15a Remove warning by casting properly in totemnet. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2283 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-22 18:50:29 +00:00
Steven Dake
76bc62a5d9 Rename request_shutdown to shutdown_request in coroapi. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2282 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-22 18:29:43 +00:00
Steven Dake
71d2a32512 Add dump_state to coroapi.h. Need to remove logging output from signal 
handlers.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2281 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-22 18:18:15 +00:00
Steven Dake
19e1f60dd3 Sanitize -p option to not set scheduling parameters in all software. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2280 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-22 05:32:41 +00:00
Jim Meyering
c424b53308 totemsrp: remove unnecessary cast to avoid "make syntax-check" failure 
* exec/totemsrp.c (message_handler_memb_join): Remove unnecessary
cast of alloca return value.

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2279 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-21 18:27:02 +00:00
Steven Dake
04cf210d9d Use HAVE_ALLOCA_H define before including alloca.h 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2278 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-21 16:46:24 +00:00
Steven Dake
0cf6c6c7db Add tests for posix scheduling apis to configure.ac and use them to determine 
if we should set scheduling priorities or not.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2277 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-21 16:33:25 +00:00
Steven Dake
cbb6aaf78b Work around dlopen'ed objects not executing constructors on solaris platform. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2276 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-21 05:02:09 +00:00
Steven Dake
66eff93187 Remove shadow warnings. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2271 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-20 17:33:38 +00:00
Steven Dake
b8e3951ca1 Add (void *) casts for iovector assignments to remove compile warnings. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2270 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 20:43:12 +00:00
Steven Dake
74c0a68ee1 Fix unused variable on linux because of portage work. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2268 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 15:53:13 +00:00
Steven Dake
589f889fbe Patch from Wojtek to fix Solaris segfault with compiler optimization. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2267 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 15:42:15 +00:00
Jim Meyering
74a2fa1194 maint: remove trailing blanks 
By running this command from a git-cloned directory:
git grep -z -l -E '[[:blank:]]+$' | xargs -0 perl -pi -e 's/[ \t]+$//'

git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2266 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 11:34:50 +00:00
Fabio M. Di Nitto
2135d91c27 Fix handling of sysconfdir 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2265 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 07:02:55 +00:00
Steven Dake
2d7937de26 Warn user of missing dirs and exit gracefully. 
git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2262 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 01:53:24 +00:00
Steven Dake
bc87f196f7 Remove requirement of having uid and gid of "ais" on the system and allow 
nonroot users to access ipc if their uid/gid is in the /etc/corosync/uidgid.d
directory.


git-svn-id: http://svn.fedorahosted.org/svn/corosync/trunk@2261 fd59a12c-fef9-0310-b244-a6a79926bd2f
 2009-06-19 00:03:56 +00:00