From f0e1eaff2d3c20ff0323a75f13e7838dba9153c4 Mon Sep 17 00:00:00 2001
From: liangxin1300 <XLiang@suse.com>
Date: Tue, 1 Sep 2020 11:02:37 +0800
Subject: [PATCH] totemconfig: validate totem.transport value

Signed-off-by: liangxin1300 <XLiang@suse.com>
Reviewed-by: Jan Friesse <jfriesse@redhat.com>
---
 exec/totemconfig.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/exec/totemconfig.c b/exec/totemconfig.c
index 3927da9c..45dd6ed6 100644
--- a/exec/totemconfig.c
+++ b/exec/totemconfig.c
@@ -1747,14 +1747,14 @@ extern int totem_config_read (
 	if (icmap_get_string("totem.transport", &str) == CS_OK) {
 		if (strcmp (str, "udpu") == 0) {
 			totem_config->transport_number = TOTEM_TRANSPORT_UDPU;
-		}
-
-		if (strcmp (str, "udp") == 0) {
+		} else if (strcmp (str, "udp") == 0) {
 			totem_config->transport_number = TOTEM_TRANSPORT_UDP;
-		}
-
-		if (strcmp (str, "knet") == 0) {
+		} else if (strcmp (str, "knet") == 0) {
 			totem_config->transport_number = TOTEM_TRANSPORT_KNET;
+		} else {
+			*error_string = "Invalid transport type. Should be udpu, udp or knet";
+		        free(str);
+			return -1;
 		}
 
 		free(str);