From d73ba6dd878f4016cea32f125d301a761384472d Mon Sep 17 00:00:00 2001 From: "Fabio M. Di Nitto" Date: Thu, 12 Jan 2012 09:20:06 +0100 Subject: [PATCH] cmapctl: initialize bit_value and check if it's set more gcc warnings... Reviewed-by: Steven Dake Signed-off-by: Fabio M. Di Nitto --- tools/corosync-cmapctl.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/corosync-cmapctl.c b/tools/corosync-cmapctl.c index 13da9a1d..17464c31 100644 --- a/tools/corosync-cmapctl.c +++ b/tools/corosync-cmapctl.c @@ -148,7 +148,7 @@ static void print_key(cmap_handle_t handle, cmap_value_types_t type) { char *str; - char *bin_value; + char *bin_value = NULL; cs_error_t err; int8_t i8; uint8_t u8; @@ -327,9 +327,13 @@ static void print_key(cmap_handle_t handle, printf("%s)", "bin"); if (show_binary) { printf(" = "); - print_binary_key(bin_value, value_len); - if (value == NULL) { - free(bin_value); + if (bin_value) { + print_binary_key(bin_value, value_len); + if (value == NULL) { + free(bin_value); + } + } else { + printf("*empty*"); } } break;