From 5dda71ae29dce37cddd835aaefc05cc4ddd64109 Mon Sep 17 00:00:00 2001 From: Christine Caulfield Date: Fri, 4 May 2018 10:39:53 +0100 Subject: [PATCH] knet: Fix knet log buffer size knet sends log messages as struct knet_log_msg, not a string of KNET_MAX_LOG_MSG_SIZE (which is only part of that structure). So we were both losing and corrupting messages. Signed-off-by: Christine Caulfield Reviewed-by: Jan Friesse --- exec/totemknet.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exec/totemknet.c b/exec/totemknet.c index 32ef6790..cb92c95e 100644 --- a/exec/totemknet.c +++ b/exec/totemknet.c @@ -542,7 +542,7 @@ static int log_deliver_fn ( void *data) { struct totemknet_instance *instance = (struct totemknet_instance *)data; - char buffer[KNET_MAX_LOG_MSG_SIZE*4]; + char buffer[sizeof(struct knet_log_msg)*4]; char *bufptr = buffer; int done = 0; int len; @@ -572,8 +572,8 @@ static int log_deliver_fn ( msg->msg); break; } - bufptr += KNET_MAX_LOG_MSG_SIZE; - done += KNET_MAX_LOG_MSG_SIZE; + bufptr += sizeof(struct knet_log_msg); + done += sizeof(struct knet_log_msg); } return 0; }