mirror of
https://git.proxmox.com/git/llvm-toolchain
synced 2025-06-15 12:35:11 +00:00
6f2f69cc4e
missing __tls_get_addr symbol to the symbol table for TLS calls on SPARC (Closes: #890401)
44 lines
1.9 KiB
Diff
44 lines
1.9 KiB
Diff
Description: [Sparc] Include __tls_get_addr in symbol table for TLS calls to it
|
|
Global Dynamic and Local Dynamic call relocations only implicitly
|
|
reference __tls_get_addr, but it still needs to be in the symbol table
|
|
to be bound at link time otherwise it fails to link. For details, see
|
|
https://sourceware.org/bugzilla/show_bug.cgi?id=22832.
|
|
Author: James Clarke <jrtc27@jrtc27.com>
|
|
Last-Update: 2018-02-14
|
|
|
|
--- llvm-toolchain-4.0-4.0.1.orig/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp
|
|
+++ llvm-toolchain-4.0-4.0.1/lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp
|
|
@@ -194,14 +194,30 @@ static void fixELFSymbolsInTLSFixupsImpl
|
|
void SparcMCExpr::fixELFSymbolsInTLSFixups(MCAssembler &Asm) const {
|
|
switch(getKind()) {
|
|
default: return;
|
|
+ case VK_Sparc_TLS_GD_CALL:
|
|
+ case VK_Sparc_TLS_LDM_CALL: {
|
|
+ // The corresponding relocations reference __tls_get_addr, as they call it,
|
|
+ // but this is only implicit; there is no connection in the ELF file
|
|
+ // between the relocation and the symbol, other than the specification for
|
|
+ // the semantics of the relocations. However, the symbol must be included
|
|
+ // in our symbol table despite the lack of references to it, since it needs
|
|
+ // to be bound during linking for these relocations. For details see
|
|
+ // https://sourceware.org/bugzilla/show_bug.cgi?id=22832.
|
|
+ MCSymbol *Symbol = Asm.getContext().getOrCreateSymbol("__tls_get_addr");
|
|
+ Asm.registerSymbol(*Symbol);
|
|
+ auto ELFSymbol = cast<MCSymbolELF>(Symbol);
|
|
+ if (!ELFSymbol->isBindingSet()) {
|
|
+ ELFSymbol->setBinding(ELF::STB_GLOBAL);
|
|
+ ELFSymbol->setExternal(true);
|
|
+ }
|
|
+ LLVM_FALLTHROUGH;
|
|
+ }
|
|
case VK_Sparc_TLS_GD_HI22:
|
|
case VK_Sparc_TLS_GD_LO10:
|
|
case VK_Sparc_TLS_GD_ADD:
|
|
- case VK_Sparc_TLS_GD_CALL:
|
|
case VK_Sparc_TLS_LDM_HI22:
|
|
case VK_Sparc_TLS_LDM_LO10:
|
|
case VK_Sparc_TLS_LDM_ADD:
|
|
- case VK_Sparc_TLS_LDM_CALL:
|
|
case VK_Sparc_TLS_LDO_HIX22:
|
|
case VK_Sparc_TLS_LDO_LOX10:
|
|
case VK_Sparc_TLS_LDO_ADD:
|