From 737fdba46f2b2b7d39bc728d15ea2334c44779e0 Mon Sep 17 00:00:00 2001 From: Ben Longbons Date: Fri, 29 Jun 2012 12:58:34 -0700 Subject: [PATCH] Revert "Patch to set is_stmt a little better for prologue lines in a function." This meants that the debugger could find meaningful line information. This reverts commit 60b35f408bc3194e7ea4e96367c0b42dc5e7f850. --- lib/CodeGen/AsmPrinter/DwarfDebug.cpp | 7 ++----- test/DebugInfo/X86/ending-run.ll | 6 ++---- 2 files changed, 4 insertions(+), 9 deletions(-) Index: llvm-toolchain-snapshot_3.4~svn189753/lib/CodeGen/AsmPrinter/DwarfDebug.cpp =================================================================== --- llvm-toolchain-snapshot_3.4~svn189753.orig/lib/CodeGen/AsmPrinter/DwarfDebug.cpp 2013-09-02 14:03:34.000000000 +0200 +++ llvm-toolchain-snapshot_3.4~svn189753/lib/CodeGen/AsmPrinter/DwarfDebug.cpp 2013-09-02 14:03:34.000000000 +0200 @@ -1369,15 +1369,12 @@ if (!MI->isDebugValue()) { DebugLoc DL = MI->getDebugLoc(); if (DL != PrevInstLoc && (!DL.isUnknown() || UnknownLocations)) { - unsigned Flags = 0; + unsigned Flags = DWARF2_FLAG_IS_STMT; PrevInstLoc = DL; if (DL == PrologEndLoc) { Flags |= DWARF2_FLAG_PROLOGUE_END; PrologEndLoc = DebugLoc(); } - if (PrologEndLoc.isUnknown()) - Flags |= DWARF2_FLAG_IS_STMT; - if (!DL.isUnknown()) { const MDNode *Scope = DL.getScope(Asm->MF->getFunction()->getContext()); recordSourceLine(DL.getLine(), DL.getCol(), Scope, Flags); Index: llvm-toolchain-snapshot_3.4~svn189753/test/DebugInfo/X86/ending-run.ll =================================================================== --- llvm-toolchain-snapshot_3.4~svn189753.orig/test/DebugInfo/X86/ending-run.ll 2013-09-02 14:03:34.000000000 +0200 +++ llvm-toolchain-snapshot_3.4~svn189753/test/DebugInfo/X86/ending-run.ll 2013-09-02 14:03:34.000000000 +0200 @@ -1,11 +1,9 @@ ; RUN: llc -mtriple=x86_64-apple-darwin %s -o %t -filetype=obj ; RUN: llvm-dwarfdump -debug-dump=line %t | FileCheck %s -; Check that the line table starts at 7, not 4, but that the first -; statement isn't until line 8. +; Check that the line table starts at 7, not 4. -; CHECK-NOT: 0x0000000000000000 7 0 1 0 is_stmt -; CHECK: 0x0000000000000000 7 0 1 0 +; CHECK: 0x0000000000000000 7 0 1 0 is_stmt ; CHECK: 0x0000000000000004 8 18 1 0 is_stmt prologue_end define i32 @callee(i32 %x) nounwind uwtable ssp {