mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-02 21:34:15 +00:00
f1c75b94a1
There are many different broken filemodes in the wild so we need to protect against them and give something useful up the chain. Don't fail when reading a tree from the ODB but normalize the mode as best we can. As 664 is no longer a mode that we consider to be valid and gets normalized to 644, we can stop accepting it in the treebuilder. The library won't expose it to the user, so any invalid modes are a bug.
121 lines
3.2 KiB
C
121 lines
3.2 KiB
C
#include "clar_libgit2.h"
|
|
#include "tree.h"
|
|
|
|
static const char *blob_oid = "3d0970ec547fc41ef8a5882dde99c6adce65b021";
|
|
static const char *tree_oid = "1b05fdaa881ee45b48cbaa5e9b037d667a47745e";
|
|
|
|
void test_object_tree_attributes__ensure_correctness_of_attributes_on_insertion(void)
|
|
{
|
|
git_treebuilder *builder;
|
|
git_oid oid;
|
|
|
|
cl_git_pass(git_oid_fromstr(&oid, blob_oid));
|
|
|
|
cl_git_pass(git_treebuilder_create(&builder, NULL));
|
|
|
|
cl_git_fail(git_treebuilder_insert(NULL, builder, "one.txt", &oid, (git_filemode_t)0777777));
|
|
cl_git_fail(git_treebuilder_insert(NULL, builder, "one.txt", &oid, (git_filemode_t)0100666));
|
|
cl_git_fail(git_treebuilder_insert(NULL, builder, "one.txt", &oid, (git_filemode_t)0000001));
|
|
|
|
git_treebuilder_free(builder);
|
|
}
|
|
|
|
void test_object_tree_attributes__group_writable_tree_entries_created_with_an_antique_git_version_can_still_be_accessed(void)
|
|
{
|
|
git_repository *repo;
|
|
git_oid tid;
|
|
git_tree *tree;
|
|
const git_tree_entry *entry;
|
|
|
|
cl_git_pass(git_repository_open(&repo, cl_fixture("deprecated-mode.git")));
|
|
|
|
cl_git_pass(git_oid_fromstr(&tid, tree_oid));
|
|
cl_git_pass(git_tree_lookup(&tree, repo, &tid));
|
|
|
|
entry = git_tree_entry_byname(tree, "old_mode.txt");
|
|
cl_assert_equal_i(
|
|
GIT_FILEMODE_BLOB,
|
|
git_tree_entry_filemode(entry));
|
|
|
|
git_tree_free(tree);
|
|
git_repository_free(repo);
|
|
}
|
|
|
|
void test_object_tree_attributes__treebuilder_reject_invalid_filemode(void)
|
|
{
|
|
git_repository *repo;
|
|
git_treebuilder *builder;
|
|
git_oid bid, tid;
|
|
git_tree *tree;
|
|
const git_tree_entry *entry;
|
|
|
|
repo = cl_git_sandbox_init("deprecated-mode.git");
|
|
|
|
cl_git_pass(git_oid_fromstr(&bid, blob_oid));
|
|
|
|
cl_git_pass(git_treebuilder_create(&builder, NULL));
|
|
|
|
cl_git_fail(git_treebuilder_insert(
|
|
&entry,
|
|
builder,
|
|
"normalized.txt",
|
|
&bid,
|
|
GIT_FILEMODE_BLOB_GROUP_WRITABLE));
|
|
|
|
git_treebuilder_free(builder);
|
|
cl_git_sandbox_cleanup();
|
|
}
|
|
|
|
void test_object_tree_attributes__normalize_attributes_when_creating_a_tree_from_an_existing_one(void)
|
|
{
|
|
git_repository *repo;
|
|
git_treebuilder *builder;
|
|
git_oid tid, tid2;
|
|
git_tree *tree;
|
|
const git_tree_entry *entry;
|
|
|
|
repo = cl_git_sandbox_init("deprecated-mode.git");
|
|
|
|
cl_git_pass(git_oid_fromstr(&tid, tree_oid));
|
|
cl_git_pass(git_tree_lookup(&tree, repo, &tid));
|
|
|
|
cl_git_pass(git_treebuilder_create(&builder, tree));
|
|
|
|
entry = git_treebuilder_get(builder, "old_mode.txt");
|
|
cl_assert_equal_i(
|
|
GIT_FILEMODE_BLOB,
|
|
git_tree_entry_filemode(entry));
|
|
|
|
cl_git_pass(git_treebuilder_write(&tid2, repo, builder));
|
|
git_treebuilder_free(builder);
|
|
git_tree_free(tree);
|
|
|
|
cl_git_pass(git_tree_lookup(&tree, repo, &tid2));
|
|
entry = git_tree_entry_byname(tree, "old_mode.txt");
|
|
cl_assert_equal_i(
|
|
GIT_FILEMODE_BLOB,
|
|
git_tree_entry_filemode(entry));
|
|
|
|
git_tree_free(tree);
|
|
cl_git_sandbox_cleanup();
|
|
}
|
|
|
|
void test_object_tree_attributes__normalize_600(void)
|
|
{
|
|
git_oid id;
|
|
git_tree *tree;
|
|
git_repository *repo;
|
|
const git_tree_entry *entry;
|
|
|
|
repo = cl_git_sandbox_init("deprecated-mode.git");
|
|
|
|
git_oid_fromstr(&id, "0810fb7818088ff5ac41ee49199b51473b1bd6c7");
|
|
cl_git_pass(git_tree_lookup(&tree, repo, &id));
|
|
|
|
entry = git_tree_entry_byname(tree, "ListaTeste.xml");
|
|
cl_assert_equal_i(entry->attr, GIT_FILEMODE_BLOB);
|
|
|
|
git_tree_free(tree);
|
|
cl_git_sandbox_cleanup();
|
|
}
|