mirror of
https://git.proxmox.com/git/libgit2
synced 2025-12-04 02:10:56 +00:00
It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5 did not fix the GIT_USUSED behavior on all platforms. This commit walks through and really cleans things up more thoroughly, getting rid of the unnecessary stuff. To remove the use of some GIT_UNUSED, I ended up adding a couple of new iterators for hashtables that allow you to iterator just over keys or just over values. In making this change, I found a bug in the clar tests (where we were doing *count++ but meant to do (*count)++ to increment the value). I fixed that but then found the test failing because it was not really using an empty repo. So, I took some of the code that I wrote for iterator testing and moved it to clar_helpers.c, then made use of that to make it easier to open fixtures on a per test basis even within a single test file. |
||
|---|---|---|
| .. | ||
| attr | ||
| buf | ||
| commit | ||
| config | ||
| core | ||
| diff | ||
| index | ||
| network | ||
| notes | ||
| object | ||
| odb | ||
| refs | ||
| repo | ||
| revwalk | ||
| status | ||
| clar | ||
| clar_helpers.c | ||
| clar_libgit2.h | ||
| README.md | ||
Writing Clar tests for libgit2
For information on the Clar testing framework and a detailed introduction please visit:
https://github.com/tanoku/clar
-
Write your modules and tests. Use good, meaningful names.
-
Make sure you actually build the tests by setting:
cmake -DBUILD_CLAR=ON build/ -
Test:
./build/libgit2_clar -
Make sure everything is fine.
-
Send your pull request. That's it.