mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-28 13:36:17 +00:00
a64119e396
Disallow:
1. paths with trailing dot
2. paths with trailing space
3. paths with trailing colon
4. paths that are 8.3 short names of .git folders ("GIT~1")
5. paths that are reserved path names (COM1, LPT1, etc).
6. paths with reserved DOS characters (colons, asterisks, etc)
These paths would (without \\?\ syntax) be elided to other paths - for
example, ".git." would be written as ".git". As a result, writing these
paths literally (using \\?\ syntax) makes them hard to operate with from
the shell, Windows Explorer or other tools. Disallow these.
252 lines
6.9 KiB
C
252 lines
6.9 KiB
C
#include "clar_libgit2.h"
|
|
#include "checkout_helpers.h"
|
|
|
|
#include "git2/checkout.h"
|
|
#include "repository.h"
|
|
#include "buffer.h"
|
|
#include "fileops.h"
|
|
|
|
static const char *repo_name = "nasty";
|
|
static git_repository *repo;
|
|
static git_checkout_options checkout_opts;
|
|
|
|
void test_checkout_nasty__initialize(void)
|
|
{
|
|
repo = cl_git_sandbox_init(repo_name);
|
|
|
|
GIT_INIT_STRUCTURE(&checkout_opts, GIT_CHECKOUT_OPTIONS_VERSION);
|
|
checkout_opts.checkout_strategy = GIT_CHECKOUT_FORCE;
|
|
}
|
|
|
|
void test_checkout_nasty__cleanup(void)
|
|
{
|
|
cl_git_sandbox_cleanup();
|
|
}
|
|
|
|
void test_checkout_fails(const char *refname, const char *filename)
|
|
{
|
|
git_oid commit_id;
|
|
git_commit *commit;
|
|
git_checkout_options opts = GIT_CHECKOUT_OPTIONS_INIT;
|
|
git_buf path = GIT_BUF_INIT;
|
|
|
|
cl_git_pass(git_buf_joinpath(&path, repo_name, filename));
|
|
|
|
cl_git_pass(git_reference_name_to_id(&commit_id, repo, refname));
|
|
cl_git_pass(git_commit_lookup(&commit, repo, &commit_id));
|
|
|
|
opts.checkout_strategy = GIT_CHECKOUT_FORCE;
|
|
|
|
cl_git_fail(git_checkout_tree(repo, (const git_object *)commit, &opts));
|
|
cl_assert(!git_path_exists(path.ptr));
|
|
|
|
git_commit_free(commit);
|
|
git_buf_free(&path);
|
|
}
|
|
|
|
/* A tree that contains ".git" as a tree, with a blob inside
|
|
* (".git/foobar").
|
|
*/
|
|
void test_checkout_nasty__dotgit_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotgit_tree", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains ".GIT" as a tree, with a blob inside
|
|
* (".GIT/foobar").
|
|
*/
|
|
void test_checkout_nasty__dotcapitalgit_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotcapitalgit_tree", ".GIT/foobar");
|
|
}
|
|
|
|
/* A tree that contains a tree ".", with a blob inside ("./foobar").
|
|
*/
|
|
void test_checkout_nasty__dot_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_tree", "foobar");
|
|
}
|
|
|
|
/* A tree that contains a tree ".", with a tree ".git", with a blob
|
|
* inside ("./.git/foobar").
|
|
*/
|
|
void test_checkout_nasty__dot_dotgit_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_dotgit_tree", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains a tree, with a tree "..", with a tree ".git", with a
|
|
* blob inside ("foo/../.git/foobar").
|
|
*/
|
|
void test_checkout_nasty__dotdot_dotgit_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotdot_dotgit_tree", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains a tree, with a tree "..", with a blob inside
|
|
* ("foo/../foobar").
|
|
*/
|
|
void test_checkout_nasty__dotdot_tree(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotdot_tree", "foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name ".git/foobar" */
|
|
void test_checkout_nasty__dotgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotgit_path", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name ".GIT/foobar" */
|
|
void test_checkout_nasty__dotcapitalgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotcapitalgit_path", ".GIT/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "./.git/foobar" */
|
|
void test_checkout_nasty__dot_dotgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_dotgit_path", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "./.GIT/foobar" */
|
|
void test_checkout_nasty__dot_dotcapitalgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_dotcapitalgit_path", ".GIT/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "foo/../.git/foobar" */
|
|
void test_checkout_nasty__dotdot_dotgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotdot_dotgit_path", ".git/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "foo/../.GIT/foobar" */
|
|
void test_checkout_nasty__dotdot_dotcapitalgit_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotdot_dotcapitalgit_path", ".GIT/foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "foo/." */
|
|
void test_checkout_nasty__dot_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_path", "./foobar");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "foo/." */
|
|
void test_checkout_nasty__dot_path_two(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dot_path_two", "foo/.");
|
|
}
|
|
|
|
/* A tree that contains a blob with the rogue name "foo/../foobar" */
|
|
void test_checkout_nasty__dotdot_path(void)
|
|
{
|
|
test_checkout_fails("refs/heads/dotdot_path", "foobar");
|
|
}
|
|
|
|
/* A tree that contains an entry with a backslash ".git\foobar" */
|
|
void test_checkout_nasty__dotgit_backslash_path(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dotgit_backslash_path", ".git/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry with a backslash ".GIT\foobar" */
|
|
void test_checkout_nasty__dotcapitalgit_backslash_path(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dotcapitalgit_backslash_path", ".GIT/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry with a backslash ".\.GIT\foobar" */
|
|
void test_checkout_nasty__dot_backslash_dotcapitalgit_path(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dot_backslash_dotcapitalgit_path", ".GIT/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry ".git.", because Win32 APIs will drop the
|
|
* trailing slash.
|
|
*/
|
|
void test_checkout_nasty__dot_git_dot(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dot_git_dot", ".git/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry "git~1", because that is typically the
|
|
* short name for ".git".
|
|
*/
|
|
void test_checkout_nasty__git_tilde1(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/git_tilde1", ".git/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry "git~2", when we have forced the short
|
|
* name for ".git" into "GIT~2".
|
|
*/
|
|
void test_checkout_nasty__git_custom_shortname(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
cl_must_pass(p_rename("nasty/.git", "nasty/_temp"));
|
|
cl_git_write2file("nasty/git~1", "", 0, O_RDWR|O_CREAT, 0666);
|
|
cl_must_pass(p_rename("nasty/_temp", "nasty/.git"));
|
|
test_checkout_fails("refs/heads/git_tilde2", ".git/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry "git~3", which should be allowed, since
|
|
* it is not the typical short name ("GIT~1") or the actual short name
|
|
* ("GIT~2") for ".git".
|
|
*/
|
|
void test_checkout_nasty__only_looks_like_a_git_shortname(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
git_oid commit_id;
|
|
git_commit *commit;
|
|
git_checkout_options opts = GIT_CHECKOUT_OPTIONS_INIT;
|
|
|
|
cl_must_pass(p_rename("nasty/.git", "nasty/_temp"));
|
|
cl_git_write2file("nasty/git~1", "", 0, O_RDWR|O_CREAT, 0666);
|
|
cl_must_pass(p_rename("nasty/_temp", "nasty/.git"));
|
|
|
|
cl_git_pass(git_reference_name_to_id(&commit_id, repo, "refs/heads/git_tilde3"));
|
|
cl_git_pass(git_commit_lookup(&commit, repo, &commit_id));
|
|
|
|
opts.checkout_strategy = GIT_CHECKOUT_FORCE;
|
|
|
|
cl_git_pass(git_checkout_tree(repo, (const git_object *)commit, &opts));
|
|
cl_assert(git_path_exists("nasty/git~3/foobar"));
|
|
|
|
git_commit_free(commit);
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry "git:", because Win32 APIs will reject
|
|
* that as looking too similar to a drive letter.
|
|
*/
|
|
void test_checkout_nasty__dot_git_colon(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dot_git_colon", ".git/foobar");
|
|
#endif
|
|
}
|
|
|
|
/* A tree that contains an entry "git:foo", because Win32 APIs will turn
|
|
* that into ".git".
|
|
*/
|
|
void test_checkout_nasty__dot_git_colon_stuff(void)
|
|
{
|
|
#ifdef GIT_WIN32
|
|
test_checkout_fails("refs/heads/dot_git_colon_stuff", ".git/foobar");
|
|
#endif
|
|
}
|
|
|