mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-09 05:28:34 +00:00
854eccbb2d
It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5 did not fix the GIT_USUSED behavior on all platforms. This commit walks through and really cleans things up more thoroughly, getting rid of the unnecessary stuff. To remove the use of some GIT_UNUSED, I ended up adding a couple of new iterators for hashtables that allow you to iterator just over keys or just over values. In making this change, I found a bug in the clar tests (where we were doing *count++ but meant to do (*count)++ to increment the value). I fixed that but then found the test failing because it was not really using an empty repo. So, I took some of the code that I wrote for iterator testing and moved it to clar_helpers.c, then made use of that to make it easier to open fixtures on a per test basis even within a single test file.
149 lines
3.0 KiB
C
149 lines
3.0 KiB
C
#include "clar_libgit2.h"
|
|
|
|
static const char *_name = "remote.fancy.url";
|
|
|
|
void test_config_multivar__initialize(void)
|
|
{
|
|
cl_fixture_sandbox("config");
|
|
}
|
|
|
|
void test_config_multivar__cleanup(void)
|
|
{
|
|
cl_fixture_cleanup("config");
|
|
}
|
|
|
|
static int mv_read_cb(const char *name, const char *value, void *data)
|
|
{
|
|
int *n = (int *) data;
|
|
|
|
GIT_UNUSED(value);
|
|
|
|
if (!strcmp(name, _name))
|
|
(*n)++;
|
|
|
|
return 0;
|
|
}
|
|
|
|
void test_config_multivar__foreach(void)
|
|
{
|
|
git_config *cfg;
|
|
int n = 0;
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, cl_fixture("config/config11")));
|
|
|
|
cl_git_pass(git_config_foreach(cfg, mv_read_cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
git_config_free(cfg);
|
|
}
|
|
|
|
static int cb(const char *val, void *data)
|
|
{
|
|
int *n = (int *) data;
|
|
|
|
GIT_UNUSED(val);
|
|
|
|
(*n)++;
|
|
|
|
return GIT_SUCCESS;
|
|
}
|
|
|
|
void test_config_multivar__get(void)
|
|
{
|
|
git_config *cfg;
|
|
int n;
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, "example", cb, &n));
|
|
cl_assert(n == 1);
|
|
|
|
git_config_free(cfg);
|
|
}
|
|
|
|
void test_config_multivar__add(void)
|
|
{
|
|
git_config *cfg;
|
|
int n;
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
cl_git_pass(git_config_set_multivar(cfg, _name, "nonexistant", "git://git.otherplace.org/libgit2"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 3);
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, "otherplace", cb, &n));
|
|
cl_assert(n == 1);
|
|
|
|
git_config_free(cfg);
|
|
|
|
/* We know it works in memory, let's see if the file is written correctly */
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 3);
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, "otherplace", cb, &n));
|
|
cl_assert(n == 1);
|
|
|
|
git_config_free(cfg);
|
|
}
|
|
|
|
void test_config_multivar__replace(void)
|
|
{
|
|
git_config *cfg;
|
|
int n;
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
cl_git_pass(git_config_set_multivar(cfg, _name, "github", "git://git.otherplace.org/libgit2"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
git_config_free(cfg);
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, NULL, cb, &n));
|
|
cl_assert(n == 2);
|
|
}
|
|
|
|
void test_config_multivar__replace_multiple(void)
|
|
{
|
|
git_config *cfg;
|
|
int n;
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
cl_git_pass(git_config_set_multivar(cfg, _name, "git://", "git://git.otherplace.org/libgit2"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, "otherplace", cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
git_config_free(cfg);
|
|
|
|
cl_git_pass(git_config_open_ondisk(&cfg, "config/config11"));
|
|
|
|
n = 0;
|
|
cl_git_pass(git_config_get_multivar(cfg, _name, "otherplace", cb, &n));
|
|
cl_assert(n == 2);
|
|
|
|
}
|