Go to file
Vicent Marti 761aa2aa35 tree: Fix wrong sort order when querying entries
Fixes #127 (that was quite an outstanding issue).

Rationale:

The tree objects on Git are stored and read following a very specific
sorting algorithm that places folders before files. That original sort
was the sort we were storing on memory, but this sort was being queried
with a binary search that used a simple `strcmp` for comparison, so
there were many instances where the search was failing.

Obviously, the most straightforward way to fix this is changing the
binary search CB to use the same comparison method as the sorting CB.
The problem with this is that the binary search callback compares a path
and an entry, so there is no way to know if the given path is a folder
or a standard file.

How do we work around this? Instead of splitting the `entry_byname`
method in two (one for searching directories and one for searching
normal files), we just assume that the path we are searching for is of
the same kind as the path it's being compared at the moment.

	return git_futils_cmp_path(
		ksearch->filename, ksearch->filename_len, entry->attr & 040000,
        entry->filename, entry->filename_len, entry->attr & 040000);

Since there cannot be a folder and a regular file with the same name on
the same tree, the most basic equality check will always fail
for all comparsions, until our path is compared with the actual entry we
are looking for; in this case, the matching will succeed with the file
type of the entry -- whatever it was initially.

I hope that makes sense.

PS: While I was at it, I switched the cmp methods to use cached values
for the length of each filename. That makes searches and sorts
retardedly fast -- I was wondering the reason of the performance hiccups
on massive trees; it's because of 2*strlen for each comparsion call.
2011-07-13 02:49:47 +02:00
deps/zlib zlib: Declare preprocessor directives at build time 2011-07-01 17:34:27 +02:00
examples examples/general: fix misc warnings 2011-07-05 14:20:10 +03:00
include config: Rename del to `delete 2011-07-12 02:38:20 +02:00
src tree: Fix wrong sort order when querying entries 2011-07-13 02:49:47 +02:00
tests status: refactor the tests to remove some code duplication 2011-07-12 22:20:15 +02:00
.gitattributes Add git attributes settings for *.c and *.h to force line endings to LF. 2011-05-08 12:30:16 -07:00
.gitignore Ignore CMake files and generated Visual Studio files 2011-05-18 17:31:18 +02:00
.HEADER Switch the license from BSD to GPL+libgcc exception 2008-11-01 15:55:47 -07:00
api.docurium update examples content to be compilable and up to date 2011-06-15 09:40:06 -07:00
CMakeLists.txt Fix network MSYS compilation 2011-07-06 12:48:23 +02:00
CONVENTIONS Move include files to include/git/, drop git_ prefix from file names 2008-11-01 15:42:23 -07:00
COPYING cleanup: remove trailing spaces 2011-07-01 18:02:56 +02:00
git.git-authors Correct Adam Simpkins' name 2010-04-15 09:57:58 +02:00
libgit2.pc.in Add proper version management 2011-02-07 10:35:58 +02:00
Makefile.embed build: Add simple Makefile for embedding the library 2011-07-06 02:17:15 +02:00
README.md Merge pull request #321 from letolabs/readme 2011-07-12 11:26:25 -07:00

libgit2 - the Git linkable library

libgit2 is a portable, pure C implementation of the Git core methods provided as a re-entrant linkable library with a solid API, allowing you to write native speed custom Git applications in any language with bindings.

libgit2 is licensed under a very permissive license (GPLv2 with a special Linking Exception). This basically means that you can link it (unmodified) with any kind of software without having to release its source code.

What It Can Do

libgit2 is already very usable.

  • SHA conversions, formatting and shortening
  • abstracked ODB backend system
  • commit, tag, tree and blob parsing, editing, and write-back
  • tree traversal
  • revision walking
  • index file (staging area) manipulation
  • reference management (including packed references)
  • config file management
  • high level repository management
  • thread safety and reentrancy
  • descriptive and detailed error messages
  • ...and more (over 175 different API calls)

Building libgit2 - Using CMake

libgit2 builds cleanly on most platforms without any external dependencies. Under Unix-like systems, like Linux, * BSD and Mac OS X, libgit2 expects pthreads to be available; they should be installed by default on all systems. Under Windows, libgit2 uses the native Windows API for threading.

The libgit2 library is built using CMake 2.6+ (http://www.cmake.org) on all platforms.

On most systems you can build the library using the following commands

$ mkdir build && cd build
$ cmake ..
$ cmake --build .

Alternatively you can point the CMake GUI tool to the CMakeLists.txt file and generate platform specific build project or IDE workspace.

To install the library you can specify the install prefix by setting:

$ cmake .. -DCMAKE_INSTALL_PREFIX=/install/prefix
$ cmake --build . --target install

For more advanced use or questions about CMake please read http://www.cmake.org/Wiki/CMake_FAQ.

The following CMake variables are declared:

  • INSTALL_BIN: Where to install binaries to.
  • INSTALL_LIB: Where to install libraries to.
  • INSTALL_INC: Where to install headers to.
  • BUILD_SHARED_LIBS: Build libgit2 as a Shared Library (defaults to ON)
  • BUILD_TESTS: Build the libgit2 test suite (defaults to ON)
  • THREADSAFE: Build libgit2 with threading support (defaults to OFF)

Language Bindings

Here are the bindings to libgit2 that are currently available:

If you start another language binding to libgit2, please let us know so we can add it to the list.

How Can I Contribute

Fork libgit2/libgit2 on GitHub, add your improvement, push it to a branch in your fork named for the topic, send a pull request.

You can also file bugs or feature requests under the libgit2 project on GitHub, or join us on the mailing list by sending an email to:

libgit2@librelist.com

License

libgit2 is under GPL2 with linking exemption. This means you can link to the library with any program, commercial, open source or other. However, you cannot modify libgit2 and distribute it without supplying the source.

See the COPYING file for the full license text.