mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-05 09:53:23 +00:00
46c8f7f845
Remote objects are not meant to be changed from under the user. We did this in rename, but only the name and left the refspecs, such that a save would save the wrong refspecs (and a fetch and anything else would use the wrong refspecs). Instead, let's simply take a name and not change any loaded remote from under the user.
247 lines
7.9 KiB
C
247 lines
7.9 KiB
C
#include "clar_libgit2.h"
|
|
#include "config/config_helpers.h"
|
|
|
|
#include "repository.h"
|
|
|
|
static git_repository *_repo;
|
|
static const char *_remote_name = "test";
|
|
|
|
void test_network_remote_rename__initialize(void)
|
|
{
|
|
_repo = cl_git_sandbox_init("testrepo.git");
|
|
}
|
|
|
|
void test_network_remote_rename__cleanup(void)
|
|
{
|
|
cl_git_sandbox_cleanup();
|
|
}
|
|
|
|
static int dont_call_me_cb(const char *fetch_refspec, void *payload)
|
|
{
|
|
GIT_UNUSED(fetch_refspec);
|
|
GIT_UNUSED(payload);
|
|
|
|
cl_assert(false);
|
|
|
|
return -1;
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_moves_related_configuration_section(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
assert_config_entry_existence(_repo, "remote.test.fetch", true);
|
|
assert_config_entry_existence(_repo, "remote.just/renamed.fetch", false);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
assert_config_entry_existence(_repo, "remote.test.fetch", false);
|
|
assert_config_entry_existence(_repo, "remote.just/renamed.fetch", true);
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_updates_branch_related_configuration_entries(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
assert_config_entry_value(_repo, "branch.master.remote", "test");
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
assert_config_entry_value(_repo, "branch.master.remote", "just/renamed");
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_updates_default_fetchrefspec(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
assert_config_entry_value(_repo, "remote.just/renamed.fetch", "+refs/heads/*:refs/remotes/just/renamed/*");
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_without_a_fetchrefspec_doesnt_create_one(void)
|
|
{
|
|
git_config *config;
|
|
git_remote *remote;
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_pass(git_repository_config__weakptr(&config, _repo));
|
|
cl_git_pass(git_config_delete_entry(config, "remote.test.fetch"));
|
|
|
|
cl_git_pass(git_remote_load(&remote, _repo, "test"));
|
|
git_remote_free(remote);
|
|
|
|
assert_config_entry_existence(_repo, "remote.test.fetch", false);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
assert_config_entry_existence(_repo, "remote.just/renamed.fetch", false);
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_notifies_of_non_default_fetchrefspec(void)
|
|
{
|
|
git_config *config;
|
|
git_remote *remote;
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_pass(git_repository_config__weakptr(&config, _repo));
|
|
cl_git_pass(git_config_set_string(config, "remote.test.fetch", "+refs/*:refs/*"));
|
|
cl_git_pass(git_remote_load(&remote, _repo, "test"));
|
|
git_remote_free(remote);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(1, problems.count);
|
|
cl_assert_equal_s("+refs/*:refs/*", problems.strings[0]);
|
|
git_strarray_free(&problems);
|
|
|
|
assert_config_entry_value(_repo, "remote.just/renamed.fetch", "+refs/*:refs/*");
|
|
|
|
git_strarray_free(&problems);
|
|
}
|
|
|
|
void test_network_remote_rename__new_name_can_contain_dots(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just.renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
assert_config_entry_existence(_repo, "remote.just.renamed.fetch", true);
|
|
}
|
|
|
|
void test_network_remote_rename__new_name_must_conform_to_reference_naming_conventions(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
cl_assert_equal_i(
|
|
GIT_EINVALIDSPEC,
|
|
git_remote_rename(&problems, _repo, _remote_name, "new@{name"));
|
|
}
|
|
|
|
void test_network_remote_rename__renamed_name_is_persisted(void)
|
|
{
|
|
git_remote *renamed;
|
|
git_repository *another_repo;
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_fail(git_remote_load(&renamed, _repo, "just/renamed"));
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
cl_git_pass(git_repository_open(&another_repo, "testrepo.git"));
|
|
cl_git_pass(git_remote_load(&renamed, _repo, "just/renamed"));
|
|
|
|
git_remote_free(renamed);
|
|
git_repository_free(another_repo);
|
|
}
|
|
|
|
void test_network_remote_rename__cannot_overwrite_an_existing_remote(void)
|
|
{
|
|
git_strarray problems = {0};
|
|
|
|
cl_assert_equal_i(GIT_EEXISTS, git_remote_rename(&problems, _repo, _remote_name, "test"));
|
|
cl_assert_equal_i(GIT_EEXISTS, git_remote_rename(&problems, _repo, _remote_name, "test_with_pushurl"));
|
|
}
|
|
|
|
void test_network_remote_rename__renaming_a_remote_moves_the_underlying_reference(void)
|
|
{
|
|
git_reference *underlying;
|
|
git_strarray problems = {0};
|
|
|
|
cl_assert_equal_i(GIT_ENOTFOUND, git_reference_lookup(&underlying, _repo, "refs/remotes/just/renamed"));
|
|
cl_git_pass(git_reference_lookup(&underlying, _repo, "refs/remotes/test/master"));
|
|
git_reference_free(underlying);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "just/renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
cl_assert_equal_i(GIT_ENOTFOUND, git_reference_lookup(&underlying, _repo, "refs/remotes/test/master"));
|
|
cl_git_pass(git_reference_lookup(&underlying, _repo, "refs/remotes/just/renamed/master"));
|
|
git_reference_free(underlying);
|
|
}
|
|
|
|
void test_network_remote_rename__overwrite_ref_in_target(void)
|
|
{
|
|
git_oid id;
|
|
char idstr[GIT_OID_HEXSZ + 1] = {0};
|
|
git_reference *ref;
|
|
git_branch_t btype;
|
|
git_branch_iterator *iter;
|
|
git_strarray problems = {0};
|
|
|
|
cl_git_pass(git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"));
|
|
cl_git_pass(git_reference_create(&ref, _repo, "refs/remotes/renamed/master", &id, 1, NULL, NULL));
|
|
git_reference_free(ref);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
/* make sure there's only one remote-tracking branch */
|
|
cl_git_pass(git_branch_iterator_new(&iter, _repo, GIT_BRANCH_REMOTE));
|
|
cl_git_pass(git_branch_next(&ref, &btype, iter));
|
|
cl_assert_equal_s("refs/remotes/renamed/master", git_reference_name(ref));
|
|
git_oid_fmt(idstr, git_reference_target(ref));
|
|
cl_assert_equal_s("be3563ae3f795b2b4353bcce3a527ad0a4f7f644", idstr);
|
|
git_reference_free(ref);
|
|
|
|
cl_git_fail_with(GIT_ITEROVER, git_branch_next(&ref, &btype, iter));
|
|
git_branch_iterator_free(iter);
|
|
}
|
|
|
|
void test_network_remote_rename__symref_head(void)
|
|
{
|
|
int error;
|
|
git_reference *ref;
|
|
git_branch_t btype;
|
|
git_branch_iterator *iter;
|
|
git_strarray problems = {0};
|
|
char idstr[GIT_OID_HEXSZ + 1] = {0};
|
|
git_vector refs;
|
|
|
|
cl_git_pass(git_reference_symbolic_create(&ref, _repo, "refs/remotes/test/HEAD", "refs/remotes/test/master", 0, NULL, NULL));
|
|
git_reference_free(ref);
|
|
|
|
cl_git_pass(git_remote_rename(&problems, _repo, _remote_name, "renamed"));
|
|
cl_assert_equal_i(0, problems.count);
|
|
git_strarray_free(&problems);
|
|
|
|
cl_git_pass(git_vector_init(&refs, 2, (git_vector_cmp) git_reference_cmp));
|
|
cl_git_pass(git_branch_iterator_new(&iter, _repo, GIT_BRANCH_REMOTE));
|
|
|
|
while ((error = git_branch_next(&ref, &btype, iter)) == 0) {
|
|
cl_git_pass(git_vector_insert(&refs, ref));
|
|
}
|
|
cl_assert_equal_i(GIT_ITEROVER, error);
|
|
git_vector_sort(&refs);
|
|
|
|
cl_assert_equal_i(2, refs.length);
|
|
|
|
ref = git_vector_get(&refs, 0);
|
|
cl_assert_equal_s("refs/remotes/renamed/HEAD", git_reference_name(ref));
|
|
cl_assert_equal_s("refs/remotes/renamed/master", git_reference_symbolic_target(ref));
|
|
git_reference_free(ref);
|
|
|
|
ref = git_vector_get(&refs, 1);
|
|
cl_assert_equal_s("refs/remotes/renamed/master", git_reference_name(ref));
|
|
git_oid_fmt(idstr, git_reference_target(ref));
|
|
cl_assert_equal_s("be3563ae3f795b2b4353bcce3a527ad0a4f7f644", idstr);
|
|
git_reference_free(ref);
|
|
|
|
git_vector_free(&refs);
|
|
|
|
cl_git_fail_with(GIT_ITEROVER, git_branch_next(&ref, &btype, iter));
|
|
git_branch_iterator_free(iter);
|
|
}
|