mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-06 06:42:21 +00:00
3315782cb4
The old 'git_revpool' object has been removed and split into two distinct objects with separate functionality, in order to have separate methods for object management and object walking. * A new object 'git_repository' does the high-level management of a repository's objects (commits, trees, tags, etc) on top of a 'git_odb'. Eventually, it will also manage other repository attributes (e.g. tag resolution, references, etc). See: src/git/repository.h * A new external method 'git_repository_lookup(repo, oid, type)' has been added to the 'git_repository' API. All object lookups (git_XXX_lookup()) are now wrappers to this method, and duplicated code has been removed. The method does automatic type checking and returns a generic 'git_revpool_object' that can be cast to any specific object. See: src/git/repository.h * The external methods for object parsing of repository objects (git_XXX_parse()) have been removed. Loading objects from the repository is now managed through the 'lookup' functions. These objects are loaded with minimal information, and the relevant parsing is done automatically when the user requests any of the parsed attributes through accessor methods. An attribute has been added to 'git_repository' in order to force the parsing of all the repository objects immediately after lookup. See: src/git/commit.h See: src/git/tag.h See: src/git/tree.h * The previous walking functionality of the revpool is now found in 'git_revwalk', which does the actual revision walking on a repository; the attributes when walking through commits in a database have been decoupled from the actual commit objects. This increases performance when accessing commits during the walk and allows to have several 'git_revwalk' instances working at the same time on top of the same repository, without having to load commits in memory several times. See: src/git/revwalk.h * The old 'git_revpool_table' has been renamed to 'git_hashtable' and now works as a generic hashtable with support for any kind of object and custom hash functions. See: src/hashtable.h * All the relevant unit tests have been updated, renamed and grouped accordingly. Signed-off-by: Vicent Marti <tanoku@gmail.com>
266 lines
7.3 KiB
C
266 lines
7.3 KiB
C
#include "test_lib.h"
|
|
#include "test_helpers.h"
|
|
#include "commit.h"
|
|
#include <git/odb.h>
|
|
#include <git/commit.h>
|
|
#include <git/revwalk.h>
|
|
|
|
static char *test_commits_broken[] = {
|
|
|
|
/* empty commit */
|
|
"",
|
|
|
|
/* random garbage */
|
|
"asd97sa9du902e9a0jdsuusad09as9du098709aweu8987sd\n",
|
|
|
|
/* broken endlines 1 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\r\n\
|
|
parent 05452d6349abcd67aa396dfb28660d765d8b2a36\r\n\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\r\n\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\r\n\
|
|
\r\n\
|
|
a test commit with broken endlines\r\n",
|
|
|
|
/* broken endlines 2 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\
|
|
parent 05452d6349abcd67aa396dfb28660d765d8b2a36\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\
|
|
\
|
|
another test commit with broken endlines",
|
|
|
|
/* starting endlines */
|
|
"\ntree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
parent 05452d6349abcd67aa396dfb28660d765d8b2a36\n\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
\n\
|
|
a test commit with a starting endline\n",
|
|
|
|
/* corrupted commit 1 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
parent 05452d6349abcd67aa396df",
|
|
|
|
/* corrupted commit 2 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
parent ",
|
|
|
|
/* corrupted commit 3 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
parent ",
|
|
|
|
/* corrupted commit 4 */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
par",
|
|
|
|
};
|
|
|
|
|
|
static char *test_commits_working[] = {
|
|
/* simple commit with no message */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
\n",
|
|
|
|
/* simple commit, no parent */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
\n\
|
|
a simple commit which works\n",
|
|
|
|
/* simple commit, 1 parents */
|
|
"tree f6c0dad3c7b3481caa9d73db21f91964894a945b\n\
|
|
parent a4a7dce85cf63874e984719f4fdd239f5145052f\n\
|
|
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
|
|
\n\
|
|
a simple commit which works\n",
|
|
};
|
|
|
|
BEGIN_TEST(parse_oid_test)
|
|
|
|
git_oid oid;
|
|
|
|
#define TEST_OID_PASS(string, header) { \
|
|
char *ptr = string;\
|
|
char *ptr_original = ptr;\
|
|
size_t len = strlen(ptr);\
|
|
must_pass(git__parse_oid(&oid, &ptr, ptr + len, header));\
|
|
must_be_true(ptr == ptr_original + len);\
|
|
}
|
|
|
|
#define TEST_OID_FAIL(string, header) { \
|
|
char *ptr = string;\
|
|
size_t len = strlen(ptr);\
|
|
must_fail(git__parse_oid(&oid, &ptr, ptr + len, header));\
|
|
}
|
|
|
|
TEST_OID_PASS("parent 05452d6349abcd67aa396dfb28660d765d8b2a36\n", "parent ");
|
|
TEST_OID_PASS("tree 05452d6349abcd67aa396dfb28660d765d8b2a36\n", "tree ");
|
|
TEST_OID_PASS("random_heading 05452d6349abcd67aa396dfb28660d765d8b2a36\n", "random_heading ");
|
|
TEST_OID_PASS("stuck_heading05452d6349abcd67aa396dfb28660d765d8b2a36\n", "stuck_heading");
|
|
TEST_OID_PASS("tree 5F4BEFFC0759261D015AA63A3A85613FF2F235DE\n", "tree ");
|
|
TEST_OID_PASS("tree 1A669B8AB81B5EB7D9DB69562D34952A38A9B504\n", "tree ");
|
|
TEST_OID_PASS("tree 5B20DCC6110FCC75D31C6CEDEBD7F43ECA65B503\n", "tree ");
|
|
TEST_OID_PASS("tree 173E7BF00EA5C33447E99E6C1255954A13026BE4\n", "tree ");
|
|
|
|
TEST_OID_FAIL("parent 05452d6349abcd67aa396dfb28660d765d8b2a36", "parent ");
|
|
TEST_OID_FAIL("05452d6349abcd67aa396dfb28660d765d8b2a36\n", "tree ");
|
|
TEST_OID_FAIL("parent05452d6349abcd67aa396dfb28660d765d8b2a6a\n", "parent ");
|
|
TEST_OID_FAIL("parent 05452d6349abcd67aa396dfb280d765d8b2a6\n", "parent ");
|
|
TEST_OID_FAIL("tree 05452d6349abcd67aa396dfb28660d765d8b2a36\n", "tree ");
|
|
TEST_OID_FAIL("parent 0545xd6349abcd67aa396dfb28660d765d8b2a36\n", "parent ");
|
|
TEST_OID_FAIL("parent 0545xd6349abcd67aa396dfb28660d765d8b2a36FF\n", "parent ");
|
|
TEST_OID_FAIL("", "tree ");
|
|
TEST_OID_FAIL("", "");
|
|
|
|
#undef TEST_OID_PASS
|
|
#undef TEST_OID_FAIL
|
|
|
|
END_TEST
|
|
|
|
BEGIN_TEST(parse_person_test)
|
|
|
|
#define TEST_PERSON_PASS(_string, _header, _name, _email, _time) { \
|
|
char *ptr = _string; \
|
|
size_t len = strlen(_string);\
|
|
git_person person; \
|
|
must_pass(git__parse_person(&person, &ptr, ptr + len, _header));\
|
|
must_be_true(strncmp(_name, person.name, 63) == 0);\
|
|
must_be_true(strncmp(_email, person.email, 63) == 0);\
|
|
must_be_true(_time == person.time);\
|
|
}
|
|
|
|
#define TEST_PERSON_FAIL(_string, _header) { \
|
|
char *ptr = _string; \
|
|
size_t len = strlen(_string);\
|
|
git_person person; \
|
|
must_fail(git__parse_person(&person, &ptr, ptr + len, _header));\
|
|
}
|
|
|
|
TEST_PERSON_PASS(
|
|
"author Vicent Marti <tanoku@gmail.com> 12345 \n",
|
|
"author ",
|
|
"Vicent Marti",
|
|
"tanoku@gmail.com",
|
|
12345);
|
|
|
|
TEST_PERSON_PASS(
|
|
"author Vicent Marti <> 12345 \n",
|
|
"author ",
|
|
"Vicent Marti",
|
|
"",
|
|
12345);
|
|
|
|
TEST_PERSON_PASS(
|
|
"author Vicent Marti <tanoku@gmail.com> 231301 +2020\n",
|
|
"author ",
|
|
"Vicent Marti",
|
|
"tanoku@gmail.com",
|
|
231301);
|
|
|
|
TEST_PERSON_PASS(
|
|
"author Vicent Marti with an outrageously long name \
|
|
which will probably overflow the buffer <tanoku@gmail.com> 12345 \n",
|
|
"author ",
|
|
"Vicent Marti with an outrageously long name \
|
|
which will probably overflow the buffer",
|
|
"tanoku@gmail.com",
|
|
12345);
|
|
|
|
TEST_PERSON_PASS(
|
|
"author Vicent Marti <tanokuwithaveryveryverylongemail\
|
|
whichwillprobablyvoverflowtheemailbuffer@gmail.com> 12345 \n",
|
|
"author ",
|
|
"Vicent Marti",
|
|
"tanokuwithaveryveryverylongemail\
|
|
whichwillprobablyvoverflowtheemailbuffer@gmail.com",
|
|
12345);
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti <tanoku@gmail.com> 12345 \n",
|
|
"author ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti <tanoku@gmail.com> 12345 \n",
|
|
"committer ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti 12345 \n",
|
|
"author ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti <broken@email 12345 \n",
|
|
"author ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti <tanoku@gmail.com> notime \n",
|
|
"author ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author Vicent Marti <tanoku@gmail.com>\n",
|
|
"author ");
|
|
|
|
TEST_PERSON_FAIL(
|
|
"author ",
|
|
"author ");
|
|
|
|
#undef TEST_PERSON_PASS
|
|
#undef TESt_PERSON_FAIL
|
|
|
|
END_TEST
|
|
|
|
BEGIN_TEST(parse_buffer_test)
|
|
const int broken_commit_count = sizeof(test_commits_broken) / sizeof(*test_commits_broken);
|
|
const int working_commit_count = sizeof(test_commits_working) / sizeof(*test_commits_working);
|
|
|
|
const unsigned int default_flags =
|
|
GIT_COMMIT_AUTHOR |
|
|
GIT_COMMIT_COMMITTER |
|
|
GIT_COMMIT_TIME |
|
|
GIT_COMMIT_MESSAGE |
|
|
GIT_COMMIT_MESSAGE_SHORT; /* parse everything */
|
|
|
|
int i;
|
|
git_repository *repo = git_repository_alloc(NULL);
|
|
|
|
must_be_true(repo != NULL);
|
|
|
|
for (i = 0; i < broken_commit_count; ++i) {
|
|
git_commit *commit;
|
|
commit = git__malloc(sizeof(git_commit));
|
|
memset(commit, 0x0, sizeof(git_commit));
|
|
commit->object.repo = repo;
|
|
|
|
must_fail(git_commit__parse_buffer(
|
|
commit,
|
|
test_commits_broken[i],
|
|
strlen(test_commits_broken[i]),
|
|
default_flags)
|
|
);
|
|
|
|
git_commit__free(commit);
|
|
}
|
|
|
|
for (i = 0; i < working_commit_count; ++i) {
|
|
git_commit *commit;
|
|
commit = git__malloc(sizeof(git_commit));
|
|
memset(commit, 0x0, sizeof(git_commit));
|
|
commit->object.repo = repo;
|
|
|
|
must_pass(git_commit__parse_buffer(
|
|
commit,
|
|
test_commits_working[i],
|
|
strlen(test_commits_working[i]),
|
|
default_flags)
|
|
);
|
|
|
|
git_commit__free(commit);
|
|
}
|
|
|
|
git_repository_free(repo);
|
|
|
|
END_TEST
|