Russell Belfer
56543a609a
Clear up warnings from cppcheck
...
The cppcheck static analyzer generates warnings for a bunch of
places in the libgit2 code base. All the ones fixed in this
commit are actually false positives, but I've reorganized the
code to hopefully make it easier for static analysis tools to
correctly understand the structure. I wouldn't do this if I
felt like it was making the code harder to read or worse for
humans, but in this case, these fixes don't seem too bad and will
hopefully make it easier for better analysis tools to get at any
real issues.
2013-02-15 16:02:45 -08:00
Russell Belfer
71d62d3905
Fix memory leak in p_getaddrinfo on Amiga
...
If gethostbyname() fails on platforms with NO_ADDRINFO, the code
leaks the struct addrinfo that was allocated. This fixes that
(and a number of code formatting issues in that area of code in
src/posix.c).
2013-02-15 16:01:31 -08:00
Ben Straub
a9e1339c06
Fix a leak when canceling a network operation
2013-02-14 08:12:55 -08:00
Philip Kelley
2fe67aeb10
Fix a git_filebuf leak (fixes Win32 clone::can_cancel)
2013-02-14 08:46:58 -05:00
Philip Kelley
5f633e911e
Change git2.rc to identify git.dll as VOS_NT_WINDOWS32
2013-02-13 18:12:51 -05:00
Ben Straub
6a0ffe84a7
Merge pull request #1333 from phkelley/push_options
...
Add git_push_options, to set packbuilder parallelism
2013-02-12 10:50:55 -08:00
Russell Belfer
fbe67de997
Merge pull request #1246 from arrbee/fix-force-text-for-diff-blobs
...
Add FORCE_TEXT check into git_diff_blobs code path
2013-02-12 10:16:30 -08:00
Russell Belfer
9c258af094
Merge pull request #1316 from ben/clone-cancel
...
Allow network operations to cancel
2013-02-12 10:13:56 -08:00
Russell Belfer
ed55fd8bf8
Reorganize FORCE_TEXT diff flag checks
2013-02-11 14:45:46 -08:00
Russell Belfer
c2907575ec
Add FORCE_TEXT check into git_diff_blobs code path
...
`git_diff_blobs` and `git_diff_blob_to_buffer` skip the step
where we check file attributes because they don't have a filename
associated with the data. Unfortunately, this meant they were also
skipping the check for the GIT_DIFF_FORCE_TEXT option and so you
could not force a diff of an apparent binary file. This adds the
force text check into their code path.
2013-02-11 14:45:46 -08:00
nulltoken
2bca5b679b
remote: Introduce git_remote_is_valid_name()
...
Fix libgit2/libgit2sharp#318
2013-02-11 23:19:41 +01:00
nulltoken
4d811c3b77
refs: No component of a refname can end with '.lock'
2013-02-11 23:19:40 +01:00
Russell Belfer
390a3c8141
Merge pull request #1190 from nulltoken/topic/reset-paths
...
reset: Allow the selective reset of pathspecs
2013-02-11 11:44:00 -08:00
Philip Kelley
e026cfee00
Merge pull request #1323 from jamill/resolve_remote
...
Resolve a remote branch's remote
2013-02-11 09:12:39 -08:00
Jameson Miller
db4bb4158f
Teach refspec to transform destination reference to source reference
2013-02-11 11:36:28 -05:00
Jameson Miller
2e3e8c889b
Teach remote branch to return its remote
2013-02-11 11:36:22 -05:00
Philip Kelley
b8b897bbc5
Add git_push_options, to set packbuilder parallelism
2013-02-11 09:35:26 -05:00
Philip Kelley
8c29dca6c3
Fix some incorrect MSVC #ifdef's. Fixes #1305
2013-02-11 09:25:57 -05:00
Philip Kelley
a150cc875d
Fix a bug introduced in df93a681 'Merge the push...'
2013-02-10 18:16:10 -05:00
Michael Schubert
a9d081e504
Fix -Wmaybe-uninitialized warning
2013-02-10 19:36:39 +01:00
Philip Kelley
df93a6810a
Merge the push report into the refs to avoid a 3rd network call
2013-02-08 15:21:37 -05:00
Jameson Miller
ff9df88396
Fix Windows symlinks
2013-02-08 14:28:49 -05:00
Russell Belfer
f3e492107a
Merge pull request #1249 from yorah/topic/diff-notify-unmatched-pathspecs
...
diff: Add a callback to notify of diffed files
2013-02-08 10:02:37 -08:00
Vicent Martí
5b62eb7dd7
Merge pull request #1325 from SHyx0rmZ/fix-windows-symlinks
...
Fix Windows symlinks
2013-02-08 02:50:23 -08:00
Patrick Pokatilo
7672c8c779
Moved braces to conform to code style
2013-02-08 11:29:23 +01:00
Patrick Pokatilo
64012fdbe6
Replace LoadLibrary with GetModuleHandle, since kernel32 is loaded by default
...
As requested
2013-02-08 03:24:45 +01:00
Patrick Pokatilo
a49e5bed8d
Replace call to strnlen with call to strlen
2013-02-08 01:26:04 +01:00
Patrick Pokatilo
f88885e339
Include <string.h>
2013-02-08 01:10:03 +01:00
Patrick Pokatilo
3b5e44aeba
Fix call to readlink
2013-02-08 00:50:20 +01:00
yorah
0d64ba4837
diff: add a notify callback to git_diff__from_iterators
...
The callback will be called for each file, just before the `git_delta_t` gets inserted into the diff list.
When the callback:
- returns < 0, the diff process will be aborted
- returns > 0, the delta will not be inserted into the diff list, but the diff process continues
- returns 0, the delta is inserted into the diff list, and the diff process continues
2013-02-07 20:44:35 +01:00
yorah
943700ecbb
Return the matched pathspec pattern in git_pathspec_match_path
...
Instead of returning directly the pattern as the return value, I used an
out parameter, because the function also tests if the passed pathspecs
vector is empty. If yes, it considers that the path "matches", but in
that case there is no matched pattern per se.
2013-02-07 20:44:34 +01:00
Patrick Pokatilo
94ed23f86a
Call p_readlink to determine symlink size
2013-02-07 01:41:20 +01:00
Ben Straub
f393d4e8d7
Clone: fetch all tags
2013-02-06 13:07:56 -08:00
Ben Straub
ea57f66b57
Expect standard error code from internal calls
2013-02-06 11:02:29 -08:00
Ben Straub
def60ea473
Allow all non-zero returns to cancel transfers
2013-02-05 13:14:48 -08:00
nulltoken
3ad052218c
Fix MSVC compilation warnings
...
Fix #1308
2013-02-05 20:33:27 +01:00
nulltoken
a0c34c9406
reset: Introduce git_reset_default()
2013-02-05 20:33:03 +01:00
Ben Straub
fe95ac1b67
Allow progress callback to cancel fetch
...
This works by having the indexer watch the return
code of the callback, so will only take effect
on object boundaries.
2013-02-05 10:59:58 -08:00
nulltoken
3cf58e6697
index: Fix indentations
2013-02-05 15:47:17 +01:00
Russell Belfer
de81aee390
Merge pull request #1298 from ben/user-at
...
Handle "user@" prefix for credentials partially included in URLs
2013-02-04 14:49:28 -08:00
Ben Straub
630146bd1b
Address feedback
2013-02-04 13:52:18 -08:00
nulltoken
0e8e5a6189
revparse: Lookup sha before branch
2013-02-03 11:44:26 +01:00
nulltoken
545b479a07
revparse: Lookup branch before described tag
...
Fix #1306
2013-02-03 11:18:24 +01:00
Ben Straub
15760c598d
Use malloc rather than calloc
2013-02-01 19:21:55 -08:00
Vicent Martí
e963166019
Merge pull request #1303 from csware/win32_consistent_error_encoding
...
Win32: Make sure error messages are consistently UTF-8 encoded
2013-02-01 15:57:31 -08:00
Sven Strickroth
c70455c75e
Deduplicate FormatMessage UTF-16 to UTF-8 conversion code
...
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2013-02-02 00:55:32 +01:00
Sven Strickroth
bd25a302d3
Improved error handling
...
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2013-02-02 00:52:23 +01:00
Vicent Martí
db37d3de79
Merge pull request #1299 from csware/support_local_msysgit_install
...
Support local msysgit installations
2013-02-01 15:37:45 -08:00
Sven Strickroth
89ad1c57a3
Get utf8_size from WideCharToMultiByte instead of guessing it
...
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2013-02-01 22:17:34 +01:00
Sven Strickroth
b0dc81f055
Win32: Make sure error messages are consistently UTF-8 encoded
...
W/o this a libgit2 error message could have a mixed encoding:
e.g. a filename in UTF-8 combined with a native Windows error message
encoded with the local code page.
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2013-02-01 21:54:32 +01:00