proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-06 11:19:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pack: dereference cached pack entry on error

Browse Source 
When trying to uncompress deltas in a packfile's delta chain, we try to
add object bases to the packfile cache, subsequently decrementing its
reference count if it has been added successfully. This may lead to a
mismatched reference count in the case where we exit the loop early due
to an encountered error.

Fix the issue by decrementing the reference count in error cleanup.
This commit is contained in:
Patrick Steinhardt 2016-12-12 09:36:15 +01:00
parent 8339c66068
commit ff5eea06a9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pack.c
View File

@ -757,8 +757,11 @@ int git_packfile_unpack(
} }
cleanup: cleanup:
if (error < 0) if (error < 0) {
git__free(obj->data); git__free(obj->data);
if (cached)
git_atomic_dec(&cached->refcount);
}
if (elem) if (elem)
*obj_offset = curpos; *obj_offset = curpos;