proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-07-09 14:36:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Correctly detect truncated input in header parsing

Browse Source 
If the section header is the last line in the file,
parse_section_header would incorrectly decide that the input had been
truncated.

Fix this by checking whether the actual input line is correctly
formatted.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
This commit is contained in:
Carlos Martín Nieto 2011-06-28 16:24:51 +02:00 committed by Vicent Marti
parent 86b5ab162c
commit f58c53ce66
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/config_file.c
View File

@ -721,11 +721,6 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
c = line[pos++]; c = line[pos++];
do { do {
if (cfg->reader.eof){
error = git__throw(GIT_EOBJCORRUPTED, "Failed to parse header. Config file ended unexpectedly");
goto error;
}
if (isspace(c)){ if (isspace(c)){
name[name_length] = '\0'; name[name_length] = '\0';
error = parse_section_header_ext(line, name, section_out); error = parse_section_header_ext(line, name, section_out);
@ -743,6 +738,9 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
} while ((c = line[pos++]) != ']'); } while ((c = line[pos++]) != ']');
if (line[pos - 1] != ']')
return git__throw(GIT_EOBJCORRUPTED, "Failed to parse header. Config file ended unexpectedly");
name[name_length] = 0; name[name_length] = 0;
free(line); free(line);
git__strtolower(name); git__strtolower(name);