Merge pull request #1763 from nvloff/nameless_submodule_segfault

submodule: check alloc and name presence
This commit is contained in:
Russell Belfer 2013-08-05 13:33:44 -07:00
commit ee77378d9b
2 changed files with 7 additions and 1 deletions

View File

@ -1025,6 +1025,7 @@ static int submodule_get(
if (!git_strmap_valid_index(smcfg, pos)) {
sm = submodule_alloc(repo, name);
GITERR_CHECK_ALLOC(sm);
/* insert value at name - if another thread beats us to it, then use
* their record and release our own.
@ -1101,8 +1102,10 @@ static int submodule_load_from_config(
namestart = key + strlen("submodule.");
property = strrchr(namestart, '.');
if (property == NULL)
if (!property || (property == namestart))
return 0;
property++;
is_path = (strcasecmp(property, "path") == 0);

View File

@ -1,3 +1,6 @@
[submodule "testrepo"]
path = testrepo
url =
[submodule ""]
path = testrepo
url =