proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-06 23:03:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix sparse warnings: "Using plain integer as NULL pointer"

Browse Source 
In order to suppress this warning, we could simply replace the
constant 0 with NULL. However, in this case, replacing the
comparison with 0 by !buffer is more idiomatic.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Andreas Ericsson <ae@op5.se>
This commit is contained in:
Ramsay Jones 2010-06-01 19:32:41 +01:00 committed by Andreas Ericsson
parent 468b12adb1
commit ee1765e529
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/commit.c
View File

@ -133,14 +133,14 @@ int git_commit__parse_time(time_t *commit_time, char *buffer, const char *buffer
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
buffer = memchr(buffer, '\n', buffer_end - buffer); buffer = memchr(buffer, '\n', buffer_end - buffer);
if (buffer == 0 || ++buffer >= buffer_end) if (!buffer || ++buffer >= buffer_end)
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
if (memcmp(buffer, "committer ", 10) != 0) if (memcmp(buffer, "committer ", 10) != 0)
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
buffer = memchr(buffer, '>', buffer_end - buffer); buffer = memchr(buffer, '>', buffer_end - buffer);
if (buffer == 0 || ++buffer >= buffer_end) if (!buffer || ++buffer >= buffer_end)
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
*commit_time = strtol(buffer, &buffer, 10); *commit_time = strtol(buffer, &buffer, 10);
@ -149,7 +149,7 @@ int git_commit__parse_time(time_t *commit_time, char *buffer, const char *buffer
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
buffer = memchr(buffer, '\n', buffer_end - buffer); buffer = memchr(buffer, '\n', buffer_end - buffer);
if (buffer == 0 || ++buffer >= buffer_end) if (!buffer || ++buffer >= buffer_end)
return GIT_EOBJCORRUPTED; return GIT_EOBJCORRUPTED;
return (buffer < buffer_end) ? 0 : -1; return (buffer < buffer_end) ? 0 : -1;