proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-10 07:16:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

http: enforce the credential types

Browse Source 
The user may decide to return any type of credential, including ones we
did not say we support. Add a check to make sure the user returned an
object of the right type and error out if not.
This commit is contained in:
Carlos Martín Nieto 2015-03-03 17:23:01 +01:00
parent 76f034180a
commit e892b6a927
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/transports/http.c
View File

@ -350,6 +350,11 @@ static int on_headers_complete(http_parser *parser)
} else { } else {
assert(t->cred); assert(t->cred);
if (!(t->cred->credtype & allowed_auth_types)) {
giterr_set(GITERR_NET, "credentials callback returned an invalid cred type");
return t->parse_error = PARSE_ERROR_GENERIC;
}
/* Successfully acquired a credential. */ /* Successfully acquired a credential. */
t->parse_error = PARSE_ERROR_REPLAY; t->parse_error = PARSE_ERROR_REPLAY;
return 0; return 0;