proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-09 22:39:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests::Object::Tag: Add a mechanism to test which tags were returned

Browse Source 
This patch changes the tag listing test helper to use a struct as input
parameter, which tells what we exactly expect.

As I don't think, we can rely on the fact that every os and every
filesystem will report the tags in the same order, I made this code
independent of the order that the tags are retrieved.
This commit is contained in:
Sascha Cunz 2012-09-21 00:32:53 +02:00
parent f73f760e66
commit e800bbe80a
1 changed files with 48 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
tests-clar/object/tag/list.c
View File

@ -4,26 +4,56 @@
static git_repository *g_repo; static git_repository *g_repo;
#define MAX_USED_TAGS 3
struct pattern_match_t
{
const char* pattern;
const size_t expected_matches;
const char* expected_results[MAX_USED_TAGS];
};
// Helpers // Helpers
static void ensure_tag_pattern_match(git_repository *repo, static void ensure_tag_pattern_match(git_repository *repo,
const char *pattern, const struct pattern_match_t* data)
const size_t expected_matches)
{ {
int already_found[MAX_USED_TAGS] = { 0 };
git_strarray tag_list; git_strarray tag_list;
int error = 0; int error = 0;
size_t sucessfully_found = 0;
size_t i, j;
if ((error = git_tag_list_match(&tag_list, pattern, repo)) < 0) cl_assert(data->expected_matches <= MAX_USED_TAGS);
if ((error = git_tag_list_match(&tag_list, data->pattern, repo)) < 0)
goto exit; goto exit;
if (tag_list.count != expected_matches) if (tag_list.count != data->expected_matches)
{
error = GIT_ERROR; error = GIT_ERROR;
goto exit;
}
// we have to be prepared that tags come in any order.
for (i = 0; i < tag_list.count; i++)
{
for (j = 0; j < data->expected_matches; j++)
{
if (!already_found[j] && !strcmp(data->expected_results[j], tag_list.strings[i]))
{
already_found[j] = 1;
sucessfully_found++;
break;
}
}
}
cl_assert(sucessfully_found == data->expected_matches);
exit: exit:
git_strarray_free(&tag_list); git_strarray_free(&tag_list);
cl_git_pass(error); cl_git_pass(error);
} }
// Fixture setup and teardown // Fixture setup and teardown
void test_object_tag_list__initialize(void) void test_object_tag_list__initialize(void)
{ {
@ -47,14 +77,20 @@ void test_object_tag_list__list_all(void)
git_strarray_free(&tag_list); git_strarray_free(&tag_list);
} }
static const struct pattern_match_t matches[] = {
{ "", 3, { "e90810b", "point_to_blob", "test" } },
{ "t*", 1, { "test" } },
{ "*b", 2, { "e90810b", "point_to_blob" } },
{ "e", 0 },
{ "e90810b", 1, { "e90810b" } },
{ "e90810[ab]", 1, { "e90810b" } },
{ NULL }
};
void test_object_tag_list__list_by_pattern(void) void test_object_tag_list__list_by_pattern(void)
{ {
// list all tag names from the repository matching a specified pattern // list all tag names from the repository matching a specified pattern
ensure_tag_pattern_match(g_repo, "", 3); size_t i = 0;
ensure_tag_pattern_match(g_repo, "*", 3); while (matches[i].pattern)
ensure_tag_pattern_match(g_repo, "t*", 1); ensure_tag_pattern_match(g_repo, &matches[i++]);
ensure_tag_pattern_match(g_repo, "*b", 2);
ensure_tag_pattern_match(g_repo, "e", 0);
ensure_tag_pattern_match(g_repo, "e90810b", 1);
ensure_tag_pattern_match(g_repo, "e90810[ab]", 1);
} }