From e7d0ced2192c5efeea6d9f5667d366891010b86a Mon Sep 17 00:00:00 2001 From: Russell Belfer Date: Wed, 11 Sep 2013 12:38:06 -0700 Subject: [PATCH] Fix longstanding valgrind warning There was a possible circumstance that could result in reading past the end of a buffer. This check fixes that. --- src/buf_text.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/buf_text.c b/src/buf_text.c index eda86adb3..631feb3f8 100644 --- a/src/buf_text.c +++ b/src/buf_text.c @@ -87,7 +87,7 @@ int git_buf_text_crlf_to_lf(git_buf *tgt, const git_buf *src) } /* Do not drop \r unless it is followed by \n */ - if (next[1] != '\n') + if (next + 1 == scan_end || next[1] != '\n') *out++ = '\r'; }