proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-11-03 08:02:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix git_submodule_sync writing URL to wrong key.

Browse Source 
Currently git_submodule_sync writes the submodule's URL to the
key 'branch.<REMOTE_NAME>.remote' while the reference
implementation of `git submodule sync` writes to
'remote.<REMOTE_NAME>.url', which is the intended behavior
according to git-submodule(1).
This commit is contained in:
Patrick Steinhardt 2015-03-12 16:05:07 +01:00
parent 15f581747c
commit e6903ea278
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/submodule.c
View File

@ -1091,10 +1091,10 @@ int git_submodule_sync(git_submodule *sm)
/* return error from reading submodule config */;
else if ((error = lookup_head_remote_key(&remote_name, smrepo)) < 0) {
giterr_clear();
error = git_buf_sets(&key, "branch.origin.remote");
error = git_buf_sets(&key, "remote.origin.url");
} else {
error = git_buf_join3(
&key, '.', "branch", remote_name.ptr, "remote");
&key, '.', "remote", remote_name.ptr, "url");
git_buf_free(&remote_name);
}

6
tests/submodule/modify.c
View File

@ -118,11 +118,11 @@ void test_submodule_modify__sync(void)
/* check that submodule config is updated */
assert_submodule_url_is_synced(
sm1, "submodule."SM1".url", "branch.origin.remote");
sm1, "submodule."SM1".url", "remote.origin.url");
assert_submodule_url_is_synced(
sm2, "submodule."SM2".url", "branch.origin.remote");
sm2, "submodule."SM2".url", "remote.origin.url");
assert_submodule_url_is_synced(
sm3, "submodule."SM3".url", "branch.origin.remote");
sm3, "submodule."SM3".url", "remote.origin.url");
git_submodule_free(sm1);
git_submodule_free(sm2);