proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-12-24 22:56:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Proposal to handle default value (auto = 0)

Browse Source
This commit is contained in:
yorah 2013-05-30 18:06:54 +02:00
parent 215af2ccb8
commit df50512aeb
3 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/git2/remote.h
View File

@ -426,10 +426,9 @@ GIT_EXTERN(int) git_remote_set_callbacks(git_remote *remote, git_remote_callback
GIT_EXTERN(const git_transfer_progress *) git_remote_stats(git_remote *remote);
typedef enum {
GIT_REMOTE_DOWNLOAD_TAGS_UNSET,
GIT_REMOTE_DOWNLOAD_TAGS_NONE,
GIT_REMOTE_DOWNLOAD_TAGS_AUTO,
GIT_REMOTE_DOWNLOAD_TAGS_ALL
GIT_REMOTE_DOWNLOAD_TAGS_AUTO = 0,
GIT_REMOTE_DOWNLOAD_TAGS_NONE = 1,
GIT_REMOTE_DOWNLOAD_TAGS_ALL = 2
} git_remote_autotag_option_t;
/**

1
src/clone.c
View File

@ -422,7 +422,6 @@ static void normalize_options(git_clone_options *dst, const git_clone_options *s
/* Provide defaults for null pointers */
if (!dst->remote_name) dst->remote_name = "origin";
if (!dst->remote_autotag) dst->remote_autotag = GIT_REMOTE_DOWNLOAD_TAGS_AUTO;
}
int git_clone(

7
src/remote.c
View File

@ -48,8 +48,7 @@ static int download_tags_value(git_remote *remote, git_config *cfg)
git_buf buf = GIT_BUF_INIT;
int error;
/* This is the default, let's see if we need to change it */
remote->download_tags = GIT_REMOTE_DOWNLOAD_TAGS_AUTO;
/* The 0 value is the default (auto), let's see if we need to change it */
if (git_buf_printf(&buf, "remote.%s.tagopt", remote->name) < 0)
return -1;
@ -117,9 +116,6 @@ static int create_internal(git_remote **out, git_repository *repo, const char *n
if (!name)
/* A remote without a name doesn't download tags */
remote->download_tags = GIT_REMOTE_DOWNLOAD_TAGS_NONE;
else
/* the default for a newly created remote is auto */
remote->download_tags = GIT_REMOTE_DOWNLOAD_TAGS_AUTO;
*out = remote;
git_buf_free(&fetchbuf);
@ -245,7 +241,6 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
git_config *config;
struct refspec_cb_data data;
assert(out && repo && name);
if ((error = ensure_remote_name_is_valid(name)) < 0)