proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-21 22:21:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

git_remote_ls() should return an error if the transport is not available

Browse Source
This commit is contained in:
Jacques Germishuys 2014-08-15 22:51:19 +02:00
parent e1c4429038
commit dc8adda4f1
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/remote.c
View File

@ -699,6 +699,11 @@ int git_remote_ls(const git_remote_head ***out, size_t *size, git_remote *remote
{ {
assert(remote); assert(remote);
if (!remote->transport) {
giterr_set(GITERR_NET, "No transport bound to this remote");
return -1;
}
return remote->transport->ls(out, size, remote->transport); return remote->transport->ls(out, size, remote->transport);
} }
@ -1942,6 +1947,8 @@ int git_remote_default_branch(git_buf *out, git_remote *remote)
size_t heads_len, i; size_t heads_len, i;
int error; int error;
assert(out);
if ((error = git_remote_ls(&heads, &heads_len, remote)) < 0) if ((error = git_remote_ls(&heads, &heads_len, remote)) < 0)
return error; return error;

11
tests/network/remote/local.c
View File

@ -55,6 +55,17 @@ void test_network_remote_local__retrieve_advertised_references(void)
cl_assert_equal_i(refs_len, 28); cl_assert_equal_i(refs_len, 28);
} }
void test_network_remote_local__retrieve_advertised_before_connect(void)
{
const git_remote_head **refs;
size_t refs_len = 0;
git_buf_sets(&file_path_buf, cl_git_path_url(cl_fixture("testrepo.git")));
cl_git_pass(git_remote_create_anonymous(&remote, repo, git_buf_cstr(&file_path_buf), NULL));
cl_git_fail(git_remote_ls(&refs, &refs_len, remote));
}
void test_network_remote_local__retrieve_advertised_references_after_disconnect(void) void test_network_remote_local__retrieve_advertised_references_after_disconnect(void)
{ {
const git_remote_head **refs; const git_remote_head **refs;