proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-13 12:19:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

global: clean up crt only after freeing tls data

Browse Source 
The thread local storage is used to hold some global state that
is dynamically allocated and should be freed upon exit. On
Windows, we clean up the C run-time right after execution of
registered shutdown callbacks and before cleaning up the TLS.

When we clean up the CRT, we also cause it to analyze for memory
leaks. As we did not free the TLS yet this will lead to false
positives.

Fix the issue by first freeing the TLS and cleaning up the CRT
only afterwards.
This commit is contained in:
Patrick Steinhardt 2016-06-07 12:55:17 +02:00 committed by Carlos Martín Nieto
parent 6e0d473bee
commit d1fb89dd2f
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/global.c
View File

@ -85,11 +85,6 @@ static void shutdown_common(void)
git__free(git__user_agent); git__free(git__user_agent);
git__free(git__ssl_ciphers); git__free(git__ssl_ciphers);
#if defined(GIT_MSVC_CRTDBG)
git_win32__crtdbg_stacktrace_cleanup();
git_win32__stack_cleanup();
#endif
} }
/** /**
@ -181,6 +176,11 @@ int git_libgit2_shutdown(void)
TlsFree(_tls_index); TlsFree(_tls_index);
git_mutex_free(&git__mwindow_mutex); git_mutex_free(&git__mwindow_mutex);
#if defined(GIT_MSVC_CRTDBG)
git_win32__crtdbg_stacktrace_cleanup();
git_win32__stack_cleanup();
#endif
} }
/* Exit the lock */ /* Exit the lock */