From cffd616a7205d6b025f3736eb6c0a1ae9c3cd85d Mon Sep 17 00:00:00 2001 From: Patrick Steinhardt Date: Tue, 28 Mar 2017 09:08:41 +0200 Subject: [PATCH] path: handle error returned by `git_buf_joinpath` In the `_check_dir_contents` function, we first allocate memory for joining the directory and subdirectory together and afterwards use `git_buf_joinpath`. While this function in fact should not fail as memory is already allocated, err on the safe side and check for returned errors. --- src/path.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/path.c b/src/path.c index c3d3eb1ce..9b15c8cf9 100644 --- a/src/path.c +++ b/src/path.c @@ -700,7 +700,8 @@ static bool _check_dir_contents( return false; /* save excursion */ - git_buf_joinpath(dir, dir->ptr, sub); + if (git_buf_joinpath(dir, dir->ptr, sub) < 0) + return false; result = predicate(dir->ptr);