proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-09 20:29:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

submodule: remove some obsolete logic

Browse Source 
Remove some of the logic that was left-over from the time we had a cache
of submodules, plugging a leak of the submodule object in certain cases.
This commit is contained in:
Carlos Martín Nieto 2015-06-29 20:54:17 +02:00
parent ca2466ff40
commit cf4030b04b
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/submodule.c
View File

@ -1691,28 +1691,9 @@ static int submodule_load_from_config(
/* Deregister under name being replaced */ /* Deregister under name being replaced */
if (replaced) { if (replaced) {
git_submodule_free(sm);
git__free(replaced); git__free(replaced);
} }
/* Insert under alternate key */
if (alternate) {
void *old_sm = NULL;
if (error < 0)
goto done;
if (error > 0)
error = 0;
GIT_REFCOUNT_INC(sm); /* increase refcount for new key */
/* if we replaced an old module under this key, release the old one */
if (old_sm && ((git_submodule *)old_sm) != sm) {
git_submodule_free(old_sm);
/* TODO: log warning about multiple submodules with same path */
}
}
/* TODO: Look up path in index and if it is present but not a GITLINK /* TODO: Look up path in index and if it is present but not a GITLINK
* then this should be deleted (at least to match git's behavior) * then this should be deleted (at least to match git's behavior)
*/ */