From cef170abf2704a3e3aa109020f7041e43b5e4f71 Mon Sep 17 00:00:00 2001 From: Russell Belfer Date: Fri, 14 Mar 2014 16:45:46 -0700 Subject: [PATCH] Fix leak when using push and pop with ignores The iterator pushes and pops ignores incrementally onto a list as it traverses the directory structure so that it doesn't have to constantly recheck which ignore files apply. With the new ref counting, it wasn't decrementing the refcount on the ignores that it removed from the vector. --- src/ignore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ignore.c b/src/ignore.c index 9b3c6a8bc..0fb042a34 100644 --- a/src/ignore.c +++ b/src/ignore.c @@ -191,7 +191,10 @@ int git_ignore__pop_dir(git_ignores *ign) if (ign->dir.size >= keylen && !memcmp(ign->dir.ptr + ign->dir.size - keylen, start, keylen)) + { + git_attr_file__free(git_vector_last(&ign->ign_path)); git_vector_pop(&ign->ign_path); + } } if (--ign->depth > 0) {