From cdb6f9bf5e77b6e83d4bdc6cd75c31d0d3377800 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Mon, 20 Jun 2011 17:34:01 +0200 Subject: [PATCH] Allocate enough memory for the terminator in commit parsing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also allow space for the null-terminator when allocating the buffer in packfile_unpack_compressed. Up to now, the last newline had served as a terminator, but 858ef372 searches for a double-newline and exposes the problem. Signed-off-by: Carlos Martín Nieto --- src/odb_pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/odb_pack.c b/src/odb_pack.c index 8a88a0baa..2328f527c 100644 --- a/src/odb_pack.c +++ b/src/odb_pack.c @@ -1246,7 +1246,8 @@ static int packfile_unpack_compressed( z_stream stream; unsigned char *buffer, *in; - buffer = git__malloc(size); + buffer = git__malloc(size + 1); + memset(buffer, 0x0, size + 1); memset(&stream, 0, sizeof(stream)); stream.next_out = buffer;