From c8f16bfef992452fb4ef7622a2ecd810c1937225 Mon Sep 17 00:00:00 2001 From: schu Date: Fri, 9 Sep 2011 14:05:32 +0200 Subject: [PATCH] filebuf.c: fix unused-but-set warning write_deflate() used to ignore errors by zlib's deflate function when not compiling in DEBUG mode. Always read $result and throw an error instead. Signed-off-by: schu --- src/filebuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/filebuf.c b/src/filebuf.c index e8c5087b7..7ec914227 100644 --- a/src/filebuf.c +++ b/src/filebuf.c @@ -126,7 +126,8 @@ static int write_deflate(git_filebuf *file, void *source, size_t len) zs->avail_out = (uInt)file->buf_size; result = deflate(zs, file->flush_mode); - assert(result != Z_STREAM_ERROR); + if (result == Z_STREAM_ERROR) + return git__throw(GIT_ERROR, "Failed to deflate input"); have = file->buf_size - (size_t)zs->avail_out;