proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-21 22:32:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a "dereference of type-punned pointer" compiler warning

Browse Source 
gcc (4.4.0) issues the following warning:

    src/revobject.c:33: warning: dereferencing type-punned pointer \
        will break strict-aliasing rules

We suppress the warning by copying the first 4 bytes from the oid
structure into an 'unsigned int' using memcpy(). This will also
fix any potential alignment issues on certain platforms.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Andreas Ericsson <ae@op5.se>
This commit is contained in:
Ramsay Jones 2010-06-01 19:35:49 +01:00 committed by Andreas Ericsson
parent 6e0fa05b58
commit c1b62b2ede
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/revobject.c
View File

@ -30,7 +30,9 @@ static const double max_load_factor = 0.65;
static unsigned int git_revpool_table__hash(const git_oid *id) static unsigned int git_revpool_table__hash(const git_oid *id)
{ {
return *((unsigned int *)id->id); unsigned int r;
memcpy(&r, id->id, sizeof(r));
return r;
} }
git_revpool_table *git_revpool_table_create(unsigned int min_size) git_revpool_table *git_revpool_table_create(unsigned int min_size)