mirror of
https://git.proxmox.com/git/libgit2
synced 2025-05-09 18:22:16 +00:00
odb: don't leak when detecting id ambiguity
If we find several objects with the same prefix, we need to free the memory where we stored the earlier object. Keep track of the raw.data pointer across read_prefix calls and free it if we find another object.
This commit is contained in:
parent
cdca82c784
commit
c06e000394
@ -559,6 +559,7 @@ int git_odb_read_prefix(
|
||||
int error = GIT_ENOTFOUND;
|
||||
git_oid found_full_oid = {{0}};
|
||||
git_rawobj raw;
|
||||
void *data = NULL;
|
||||
bool found = false;
|
||||
|
||||
assert(out && db);
|
||||
@ -588,6 +589,8 @@ int git_odb_read_prefix(
|
||||
if (error)
|
||||
return error;
|
||||
|
||||
git__free(data);
|
||||
data = raw.data;
|
||||
if (found && git_oid_cmp(&full_oid, &found_full_oid))
|
||||
return git_odb__error_ambiguous("multiple matches for prefix");
|
||||
found_full_oid = full_oid;
|
||||
|
Loading…
Reference in New Issue
Block a user