proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-11 13:12:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tighten up url-connection utility

Browse Source
This commit is contained in:
Ben Straub 2013-09-26 16:48:08 -07:00
parent 256961e45d
commit b59344bf83
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/netops.c
View File

@ -584,15 +584,13 @@ int gitno_connection_data_from_url(
int error = -1; int error = -1;
const char *default_port = NULL; const char *default_port = NULL;
char *original_host = NULL; char *original_host = NULL;
bool original_use_ssl;
/* service_suffix is optional */ /* service_suffix is optional */
assert(data && url); assert(data && url);
/* Save these for comparison later */ /* Save these for comparison later */
if (data->host) original_host = data->host;
original_host = git__strdup(data->host); data->host = NULL;
original_use_ssl = data->use_ssl;
gitno_connection_data_free_ptrs(data); gitno_connection_data_free_ptrs(data);
if (!git__prefixcmp(url, prefix_http)) { if (!git__prefixcmp(url, prefix_http)) {
@ -632,10 +630,6 @@ int gitno_connection_data_from_url(
data->path = git__strdup(path); data->path = git__strdup(path);
/* Check for errors in the resulting data */ /* Check for errors in the resulting data */
if (original_use_ssl && !data->use_ssl) {
giterr_set(GITERR_NET, "Redirect from HTTPS to HTTP not allowed");
error = -1;
}
if (original_host && url[0] != '/' && strcmp(original_host, data->host)) { if (original_host && url[0] != '/' && strcmp(original_host, data->host)) {
giterr_set(GITERR_NET, "Cross host redirect not allowed"); giterr_set(GITERR_NET, "Cross host redirect not allowed");
error = -1; error = -1;