Enable warnings by default and fix warning in oid.c

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
Shawn O. Pearce 2008-11-03 18:00:49 -08:00
parent 8722a77ec3
commit b3a2f90e54
2 changed files with 3 additions and 2 deletions

View File

@ -2,7 +2,7 @@ all::
DOXYGEN = doxygen
CFLAGS = -g -O2
CFLAGS = -g -O2 -Wall
OS = unix
BASIC_CFLAGS := -Iinclude

View File

@ -49,7 +49,8 @@ int git_oid_mkstr(git_oid *out, const char *str)
{
int p;
for (p = 0; p < sizeof(out->id); p++, str += 2) {
int v = (from_hex[str[0]] << 4) | from_hex[str[1]];
int v = (from_hex[(unsigned char)str[0]] << 4)
| from_hex[(unsigned char)str[1]];
if (v < 0)
return GIT_ENOTOID;
out->id[p] = (unsigned char)v;