proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-06 07:17:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1280 from nulltoken/fix/clone-segfault

Browse Source 
clone: Prevent segfault upon faulted remote creation
This commit is contained in:
Vicent Martí 2013-01-25 12:01:36 -08:00
commit af2c03a7e9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/remote.c
View File

@ -156,6 +156,7 @@ static int ensure_remote_doesnot_exist(git_repository *repo, const char *name)
int git_remote_create(git_remote **out, git_repository *repo, const char *name, const char *url) int git_remote_create(git_remote **out, git_repository *repo, const char *name, const char *url)
{ {
git_buf buf = GIT_BUF_INIT; git_buf buf = GIT_BUF_INIT;
git_remote *remote = NULL;
int error; int error;
if ((error = ensure_remote_name_is_valid(name)) < 0) if ((error = ensure_remote_name_is_valid(name)) < 0)
@ -167,19 +168,21 @@ int git_remote_create(git_remote **out, git_repository *repo, const char *name,
if (git_buf_printf(&buf, "+refs/heads/*:refs/remotes/%s/*", name) < 0) if (git_buf_printf(&buf, "+refs/heads/*:refs/remotes/%s/*", name) < 0)
return -1; return -1;
if (create_internal(out, repo, name, url, git_buf_cstr(&buf)) < 0) if (create_internal(&remote, repo, name, url, git_buf_cstr(&buf)) < 0)
goto on_error; goto on_error;
git_buf_free(&buf); git_buf_free(&buf);
if (git_remote_save(*out) < 0) if (git_remote_save(remote) < 0)
goto on_error; goto on_error;
*out = remote;
return 0; return 0;
on_error: on_error:
git_buf_free(&buf); git_buf_free(&buf);
git_remote_free(*out); git_remote_free(remote);
return -1; return -1;
} }