proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-14 16:07:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2811 from ethomson/remote_leak

Browse Source 
remote: plug leak
This commit is contained in:
Edward Thomson 2015-01-08 17:27:58 -06:00
commit aebdbcd954
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/remote.c
View File

@ -139,7 +139,7 @@ static int canonicalize_url(git_buf *out, const char *in)
static int create_internal(git_remote **out, git_repository *repo, const char *name, const char *url, const char *fetch) static int create_internal(git_remote **out, git_repository *repo, const char *name, const char *url, const char *fetch)
{ {
git_remote *remote; git_remote *remote;
git_config *config; git_config *config = NULL;
git_buf canonical_url = GIT_BUF_INIT, fetchbuf = GIT_BUF_INIT; git_buf canonical_url = GIT_BUF_INIT, fetchbuf = GIT_BUF_INIT;
int error = -1; int error = -1;
@ -183,12 +183,12 @@ static int create_internal(git_remote **out, git_repository *repo, const char *n
remote->download_tags = GIT_REMOTE_DOWNLOAD_TAGS_NONE; remote->download_tags = GIT_REMOTE_DOWNLOAD_TAGS_NONE;
*out = remote; *out = remote;
git_buf_free(&fetchbuf); error = 0;
git_buf_free(&canonical_url);
return 0;
on_error: on_error:
git_remote_free(remote); if (error)
git_remote_free(remote);
git_config_free(config); git_config_free(config);
git_buf_free(&fetchbuf); git_buf_free(&fetchbuf);
git_buf_free(&canonical_url); git_buf_free(&canonical_url);

6
tests/submodule/init.c
View File

@ -41,6 +41,7 @@ void test_submodule_init__absolute_url(void)
git_buf_free(&absolute_url); git_buf_free(&absolute_url);
git_config_free(cfg); git_config_free(cfg);
git_submodule_free(sm);
} }
void test_submodule_init__relative_url(void) void test_submodule_init__relative_url(void)
@ -70,6 +71,7 @@ void test_submodule_init__relative_url(void)
git_buf_free(&absolute_url); git_buf_free(&absolute_url);
git_config_free(cfg); git_config_free(cfg);
git_submodule_free(sm);
} }
void test_submodule_init__relative_url_detached_head(void) void test_submodule_init__relative_url_detached_head(void)
@ -107,5 +109,7 @@ void test_submodule_init__relative_url_detached_head(void)
git_buf_free(&absolute_url); git_buf_free(&absolute_url);
git_config_free(cfg); git_config_free(cfg);
git_commit_free(head_commit);
git_reference_free(head_ref);
git_submodule_free(sm);
} }