From acd1700630ea1159a55dc5e8cee12e4a725afe18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Sun, 7 Oct 2012 11:19:19 +0200 Subject: [PATCH] remote: only keep a weak pointer in update_tips The reference is only needed inside the function. We mistakenly increased the reference counter causing the ODB not to get freed and leaking descriptors. --- src/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote.c b/src/remote.c index c01e41dce..b73af0128 100644 --- a/src/remote.c +++ b/src/remote.c @@ -467,7 +467,7 @@ int git_remote_update_tips(git_remote *remote) if (refs->length == 0) return 0; - if (git_repository_odb(&odb, remote->repo) < 0) + if (git_repository_odb__weakptr(&odb, remote->repo) < 0) return -1; if (git_refspec__parse(&tagspec, GIT_REFSPEC_TAGS, true) < 0)