From a9e1339c06795c9b5f4eb4e5b2f56b8fadf98115 Mon Sep 17 00:00:00 2001 From: Ben Straub Date: Thu, 14 Feb 2013 08:12:05 -0800 Subject: [PATCH] Fix a leak when canceling a network operation --- src/transports/smart_protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/transports/smart_protocol.c b/src/transports/smart_protocol.c index 596dba66f..75494b2c7 100644 --- a/src/transports/smart_protocol.c +++ b/src/transports/smart_protocol.c @@ -493,10 +493,11 @@ int git_smart__download_pack( git__free(pkt); } else if (pkt->type == GIT_PKT_DATA) { git_pkt_data *p = (git_pkt_data *) pkt; - if ((error = writepack->add(writepack, p->data, p->len, stats)) < 0) - goto on_error; + error = writepack->add(writepack, p->data, p->len, stats); git__free(pkt); + if (error < 0) + goto on_error; } else if (pkt->type == GIT_PKT_FLUSH) { /* A flush indicates the end of the packfile */ git__free(pkt);