proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 17:05:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Only zero sensitive information on destruction (and memory actually allocated by us)

Browse Source
This commit is contained in:
Jacques Germishuys 2014-04-18 20:05:28 +02:00
parent 043112dc1c
commit a622ff17a1
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/transports/cred.c
View File

@ -30,7 +30,6 @@ static void plaintext_free(struct git_cred *cred)
git__free(c->password); git__free(c->password);
} }
git__memzero(c, sizeof(*c));
git__free(c); git__free(c);
} }
@ -73,8 +72,13 @@ static void ssh_key_free(struct git_cred *cred)
(git_cred_ssh_key *)cred; (git_cred_ssh_key *)cred;
git__free(c->username); git__free(c->username);
git__free(c->publickey);
git__free(c->privatekey); if (c->privatekey) {
/* Zero the memory which previously held the private key */
size_t key_len = strlen(c->privatekey);
git__memzero(c->privatekey, key_len);
git__free(c->privatekey);
}
if (c->passphrase) { if (c->passphrase) {
/* Zero the memory which previously held the passphrase */ /* Zero the memory which previously held the passphrase */
@ -83,7 +87,13 @@ static void ssh_key_free(struct git_cred *cred)
git__free(c->passphrase); git__free(c->passphrase);
} }
git__memzero(c, sizeof(*c)); if (c->publickey) {
/* Zero the memory which previously held the public key */
size_t key_len = strlen(c->publickey);
git__memzero(c->publickey, key_len);
git__free(c->publickey);
}
git__free(c); git__free(c);
} }
@ -93,7 +103,6 @@ static void ssh_interactive_free(struct git_cred *cred)
git__free(c->username); git__free(c->username);
git__memzero(c, sizeof(*c));
git__free(c); git__free(c);
} }
@ -102,9 +111,14 @@ static void ssh_custom_free(struct git_cred *cred)
git_cred_ssh_custom *c = (git_cred_ssh_custom *)cred; git_cred_ssh_custom *c = (git_cred_ssh_custom *)cred;
git__free(c->username); git__free(c->username);
git__free(c->publickey);
git__memzero(c, sizeof(*c)); if (c->publickey) {
/* Zero the memory which previously held the publickey */
size_t key_len = strlen(c->publickey);
git__memzero(c->publickey, key_len);
git__free(c->publickey);
}
git__free(c); git__free(c);
} }