proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2026-01-03 19:59:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make credential clearing consistent

Browse Source 
This makes all of the credential objects use the same pattern to
clear the contents and call git__memzero when done.  Much of this
information is probably not sensitive, but it also seems better
to just clear consistently.
This commit is contained in:
Russell Belfer 2013-07-09 16:16:24 -07:00
parent 03d9b930ee
commit a4456929a8
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/transports/cred.c
View File

@ -12,16 +12,17 @@
static void plaintext_free(struct git_cred *cred)
{
git_cred_userpass_plaintext *c = (git_cred_userpass_plaintext *)cred;
size_t pass_len = strlen(c->password);
git__free(c->username);
/* Zero the memory which previously held the password */
git__memzero(c->password, pass_len);
git__free(c->password);
memset(c, 0, sizeof(*c));
if (c->password) {
size_t pass_len = strlen(c->password);
git__memzero(c->password, pass_len);
git__free(c->password);
}
git__memzero(c, sizeof(*c));
git__free(c);
}
@ -74,8 +75,7 @@ static void ssh_keyfile_passphrase_free(struct git_cred *cred)
git__free(c->passphrase);
}
memset(c, 0, sizeof(*c));
git__memzero(c, sizeof(*c));
git__free(c);
}
@ -85,11 +85,7 @@ static void ssh_publickey_free(struct git_cred *cred)
git__free(c->publickey);
c->sign_callback = NULL;
c->sign_data = NULL;
memset(c, 0, sizeof(*c));
git__memzero(c, sizeof(*c));
git__free(c);
}