proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-23 21:38:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unittest to validate config entry deletion bug.

Browse Source 
Add a unittest to validate bug #3043, where a duplicate empty config header
could cause deletion of a config entry to fail silently. The bug is currently
unresolved and this test will fail.
This commit is contained in:
Ryan Roden-Corrent 2015-04-16 10:53:22 -04:00
parent 7636f740b3
commit a060cccc0a
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/config/write.c
View File

@ -6,6 +6,7 @@ void test_config_write__initialize(void)
cl_fixture_sandbox("config/config9"); cl_fixture_sandbox("config/config9");
cl_fixture_sandbox("config/config15"); cl_fixture_sandbox("config/config15");
cl_fixture_sandbox("config/config17"); cl_fixture_sandbox("config/config17");
cl_fixture_sandbox("config/config21");
} }
void test_config_write__cleanup(void) void test_config_write__cleanup(void)
@ -13,6 +14,7 @@ void test_config_write__cleanup(void)
cl_fixture_cleanup("config9"); cl_fixture_cleanup("config9");
cl_fixture_cleanup("config15"); cl_fixture_cleanup("config15");
cl_fixture_cleanup("config17"); cl_fixture_cleanup("config17");
cl_fixture_cleanup("config21");
} }
void test_config_write__replace_value(void) void test_config_write__replace_value(void)
@ -106,6 +108,35 @@ void test_config_write__delete_value_at_specific_level(void)
git_config_free(cfg); git_config_free(cfg);
} }
/*
* This test exposes a bug where duplicate empty section headers could prevent
* deletion of config entries.
*/
void test_config_write__delete_value_with_duplicate_header(void)
{
const char *file_name = "config21";
const char *entry_name = "remote.origin.url";
git_config *cfg;
git_config_entry *entry;
/* Make sure the expected entry exists */
cl_git_pass(git_config_open_ondisk(&cfg, file_name));
cl_git_pass(git_config_get_entry(&entry, cfg, entry_name));
/* Delete that entry */
cl_git_pass(git_config_delete_entry(cfg, entry_name));
/* Reopen the file and make sure the entry no longer exists */
git_config_entry_free(entry);
git_config_free(cfg);
cl_git_pass(git_config_open_ondisk(&cfg, file_name));
cl_git_fail(git_config_get_entry(&entry, cfg, entry_name));
/* Cleanup */
git_config_entry_free(entry);
git_config_free(cfg);
}
void test_config_write__write_subsection(void) void test_config_write__write_subsection(void)
{ {
git_config *cfg; git_config *cfg;

BIN
tests/resources/config/config21 Normal file
View File

Binary file not shown.