remote: make git_remote_load() return GIT_ENOTFOUND when the remote url cannot be retrieved from the config file

This commit is contained in:
nulltoken 2012-05-07 10:57:34 +02:00
parent 2fb9d6de95
commit 9fb70f378a
2 changed files with 6 additions and 3 deletions

View File

@ -112,10 +112,8 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
goto cleanup;
}
if (git_config_get_string(config, git_buf_cstr(&buf), &val) < 0) {
error = -1;
if ((error = git_config_get_string(config, git_buf_cstr(&buf), &val)) < 0)
goto cleanup;
}
remote->repo = repo;
remote->url = git__strdup(val);

View File

@ -153,3 +153,8 @@ void test_network_remotes__list(void)
git_config_free(cfg);
}
void test_network_remotes__loading_a_missing_remote_returns_ENOTFOUND(void)
{
cl_assert_equal_i(GIT_ENOTFOUND, git_remote_load(&_remote, _repo, "just-left-few-minutes-ago"));
}