proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-19 04:38:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

signature: Fix warnings

Browse Source 
Add extra braces to avoid ambiguous if-else.

Also, free() doesn't need a check.
This commit is contained in:
Vicent Marti 2011-07-05 02:28:18 +02:00
parent a01acc47bb
commit 9f86ec52fa
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/signature.c
View File

@ -33,12 +33,8 @@ void git_signature_free(git_signature *sig)
if (sig == NULL)
return;
if (sig->name)
free(sig->name);
if (sig->email)
free(sig->email);
free(sig->name);
free(sig->email);
free(sig);
}
@ -66,11 +62,12 @@ static int process_trimming(const char *input, char **storage, const char *input
left = skip_leading_spaces(input, input_end);
right = skip_trailing_spaces(input, input_end - 1);
if (right <= left)
if (right <= left) {
if (fail_when_empty)
return git__throw(GIT_EINVALIDARGS, "Failed to trim. Input is either empty or only contains spaces");
else
right = left - 1;
}
trimmed_input_length = right - left + 1;