proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-12-30 18:05:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

repository_item_path: return ENOTFOUND when appropriate

Browse Source 
Disambiguate error values: return `GIT_ENOTFOUND` when the item cannot
exist in the repository (perhaps because the repository is inmemory or
otherwise not backed by a filesystem), return `-1` when there is a hard
failure.
This commit is contained in:
Edward Thomson 2017-06-12 12:01:10 +01:00
parent fb3fc837c6
commit 9d49a43c71
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/git2/repository.h
View File

@ -433,12 +433,12 @@ typedef enum {
* item. It will thereby honor things like the repository's
* common directory, gitdir, etc. In case a file path cannot
* exist for a given item (e.g. the working directory of a bare
* repository), an error is returned.
* repository), GIT_ENOTFOUND is returned.
*
* @param out Buffer to store the path at
* @param repo Repository to get path for
* @param item The repository item for which to retrieve the path
* @return 0 on success, otherwise a negative value
* @return 0, GIT_ENOTFOUND if the path cannot exist or an error code
*/
GIT_EXTERN(int) git_repository_item_path(git_buf *out, git_repository *repo, git_repository_item_t item);

2
src/repository.c
View File

@ -2272,7 +2272,7 @@ int git_repository_item_path(git_buf *out, git_repository *repo, git_repository_
if (parent == NULL) {
giterr_set(GITERR_INVALID, "path cannot exist in repository");
return -1;
return GIT_ENOTFOUND;
}
if (git_buf_sets(out, parent) < 0)