proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-09 20:29:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

config: lock the file for write before reading

Browse Source 
When writing a configuration file, we want to take a lock on the
new file (eg, `config.lock`) before opening the configuration file
(`config`) for reading so that we can prevent somebody from changing
the contents underneath us.
This commit is contained in:
Edward Thomson 2015-04-27 15:38:44 -04:00 committed by Edward Thomson
parent 5a70df9436
commit 9c26de0fd1
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/config_file.c
View File

@ -1789,7 +1789,12 @@ static int config_write(diskfile_backend *cfg, const char *key, const regex_t *p
struct reader *reader = git_array_get(cfg->readers, 0);
struct write_data write_data;
/* TODO: take the lock before reading */
/* Lock the file */
if ((result = git_filebuf_open(
&file, cfg->file_path, 0, GIT_CONFIG_FILE_MODE)) < 0) {
git_buf_free(&reader->buffer);
return result;
}
/* We need to read in our own config file */
result = git_futils_readbuffer(&reader->buffer, cfg->file_path);
@ -1805,16 +1810,10 @@ static int config_write(diskfile_backend *cfg, const char *key, const regex_t *p
reader->eof = 0;
data_start = reader->read_ptr;
} else {
git_filebuf_cleanup(&file);
return -1; /* OS error when reading the file */
}
/* Lock the file */
if ((result = git_filebuf_open(
&file, cfg->file_path, 0, GIT_CONFIG_FILE_MODE)) < 0) {
git_buf_free(&reader->buffer);
return result;
}
ldot = strrchr(key, '.');
name = ldot + 1;
section = git__strndup(key, ldot - key);