proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-09 15:00:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Rev-parse: proper error checking.

Browse Source
This commit is contained in:
Ben Straub 2012-05-10 15:07:04 -07:00
parent 7e79d389a4
commit 94952ded3a
1 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/revparse.c
View File

@ -169,32 +169,34 @@ static int walk_ref_history(git_object **out, git_repository *repo, const char *
giterr_set(GITERR_INVALID, "Invalid reflogspec %s", reflogspec); giterr_set(GITERR_INVALID, "Invalid reflogspec %s", reflogspec);
return GIT_ERROR; return GIT_ERROR;
} }
git_reference_lookup(&ref, repo, "HEAD");
git_reflog_read(&reflog, ref);
git_reference_free(ref);
regex_error = regcomp(&regex, "checkout: moving from (.*) to .*", REG_EXTENDED); if (!git_reference_lookup(&ref, repo, "HEAD")) {
if (regex_error != 0) { if (!git_reflog_read(&reflog, ref)) {
giterr_set_regex(&regex, regex_error); regex_error = regcomp(&regex, "checkout: moving from (.*) to .*", REG_EXTENDED);
} else { if (regex_error != 0) {
regmatch_t regexmatches[2]; giterr_set_regex(&regex, regex_error);
} else {
regmatch_t regexmatches[2];
refloglen = git_reflog_entrycount(reflog); refloglen = git_reflog_entrycount(reflog);
for (i=refloglen-1; i >= 0; i--) { for (i=refloglen-1; i >= 0; i--) {
const char *msg; const char *msg;
entry = git_reflog_entry_byindex(reflog, i); entry = git_reflog_entry_byindex(reflog, i);
msg = git_reflog_entry_msg(entry); msg = git_reflog_entry_msg(entry);
if (!regexec(&regex, msg, 2, regexmatches, 0)) { if (!regexec(&regex, msg, 2, regexmatches, 0)) {
n--; n--;
if (!n) { if (!n) {
git_buf_put(&buf, msg+regexmatches[1].rm_so, regexmatches[1].rm_eo - regexmatches[1].rm_so); git_buf_put(&buf, msg+regexmatches[1].rm_so, regexmatches[1].rm_eo - regexmatches[1].rm_so);
retcode = revparse_lookup_object(out, repo, git_buf_cstr(&buf)); retcode = revparse_lookup_object(out, repo, git_buf_cstr(&buf));
break; break;
}
}
} }
regfree(&regex);
} }
} }
regfree(&regex); git_reference_free(ref);
} }
} else { } else {
git_buf datebuf = GIT_BUF_INIT; git_buf datebuf = GIT_BUF_INIT;