Initialise the config reader in config_parse

git_config_open shouldn't have to initialise variables that are only
used inside config_parse and its callees.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
This commit is contained in:
Carlos Martín Nieto 2011-03-30 11:32:08 +02:00
parent 2974aa94c3
commit 934fcf78f2

View File

@ -86,9 +86,6 @@ int git_config_open(git_config **cfg_out, const char *path)
if(error < GIT_SUCCESS)
goto cleanup;
/* Initialise the reading position */
cfg->reader.read_ptr = cfg->reader.buffer.data;
error = config_parse(cfg);
if(error < GIT_SUCCESS)
git_config_free(cfg);
@ -599,6 +596,10 @@ static int config_parse(git_config *cfg_file)
int error = GIT_SUCCESS;
char *current_section = NULL;
/* Initialise the reading position */
cfg_file->reader.read_ptr = cfg_file->reader.buffer.data;
cfg_file->reader.eof = 0;
skip_bom(cfg_file);
while (error == GIT_SUCCESS && !cfg_file->reader.eof) {