proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-12 10:05:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

revparse: Free left side of invalid range revspecs

Browse Source 
This fixes a small memory leak in git_revparse where early returns on
errors from git_revparse_single cause a free() on the (reallocated) left
side of the revspec to be skipped.
This commit is contained in:
Evan Hanson 2013-08-15 16:25:48 +12:00
parent 1e94df08da
commit 899ec41fa1
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/revparse.c
View File

@ -912,13 +912,9 @@ int git_revparse(
rstr++; rstr++;
} }
if ((error = git_revparse_single(&revspec->from, repo, lstr)) < 0) { error = git_revparse_single(&revspec->from, repo, lstr);
return error; if (error == 0)
} error = git_revparse_single(&revspec->to, repo, rstr);
if ((error = git_revparse_single(&revspec->to, repo, rstr)) < 0) {
return error;
}
git__free((void*)lstr); git__free((void*)lstr);
} else { } else {